Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only) #32352

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

silviodonato
Copy link
Contributor

PR description:

We need a new global tag to solve #32340. This PR temporarily removes ctppsProtons from recoCTPPSTask to move on the validation of CMSSW_11_2_0_pre10, if the preparation of the new global tag will take too much time.

PR validation:

cmsDriver.py step3 --conditions auto:phase1_2021_realistic -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --geometry DB:Extended --era Run3 --eventcontent RECOSIM,MINIAODSIM,DQM --filein file:/afs/cern.ch/user/s/sdonato/ORPlxplus/CMSSW_11_2_0_pre10/src/debug_PPS/badd237c-4857-4f48-b10f-52c832f57f02_ev1126.root (see #32340.)

Backport

to be backported in 11_2_X (#32346)

@silviodonato
Copy link
Contributor Author

please test

@silviodonato
Copy link
Contributor Author

@cms-sw/reconstruction-l2 : @jan-kaspar agreed to temporarily disable PPS reco in Run-3 #32207 (comment)

@silviodonato silviodonato changed the title remove ctppsProtons only in Run-3 Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only) Dec 1, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32352/20194

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

RecoPPS/Configuration

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

urgent
to unblock the Run-3 RelVals of CMSSW_11_2_0_pre10 (see #32340)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 40ed42d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb79a0/11211/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb79a0/11211/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529563
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 34 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

Reco comparison results: 18 differences found in the comparisons

the baseline has in 4.53 step3 log

%MSG-e ExcessiveTime:  PFElecTkProducer:uncleanedOnlyPfTrackElec@streamBeginRun  30-Nov-2020 13:17:02 CET Run: 194533 Stream: 0
ExcessiveTime: Module used 1090.46 seconds of time which exceeds the error threshold configured in the Timing Service of 600 seconds.

@smuzaffar
did we have some infrastructure issue in the past 24hrs or so (e.g. access to frontier lead to similar symptoms in the past)?

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

@silviodonato
is there an issue already to re-enable this?
I worry a bit that #32340 may get lost for this context

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

+1

for #32352 40ed42d

  • as described and hopefully really temporary. ctppsProtons can be remade from miniAOD; so, this is a rather minor loss
  • jenkins tests pass and comparisons with the baseline show (relevant) differences only in the Run3 workflows showing that the ctppsProtons are not filled anymore

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

@silviodonato
is there an issue already to re-enable this?
I worry a bit that #32340 may get lost for this context

I created #32356

@smuzaffar
Copy link
Contributor

@slava77 , there has been few issues with cmseos ( https://cern.service-now.com/service-portal/?id=service_status_board ) which might be causing the failures here and massive failures in IBs

@silviodonato
Copy link
Contributor Author

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants