Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce extend flag in HGCal validation #32508

Merged
merged 1 commit into from Dec 17, 2020

Conversation

ebrondol
Copy link
Contributor

PR description:

  • Introducing extended flag in order to reduce the number of plots produced automatically in the HGCal validation.
  • For a simple validation of two samples, the amount of files produced when the --separate option is included is 10269 for a total of ~500Mb. Here follow a more detail description on which category produced more plots
    num_files_beforePR
  • This PR brings the total number of files down to 7005 for a total of ~350Mb.
    num_files_afterPR
    This corresponds at about a 30% reduction.
  • The set of plots that are excluded from the default selection were agreed with @apsallid as plots that are not needed for each single release validation.

PR validation:

  • This PR should not impact any workflow.

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Dec 16, 2020
@ebrondol
Copy link
Contributor Author

informing @rovere @felicepantaleo

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32508/20443

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebrondol (Erica Brondolin) for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@ebrondol can you please add Subsystem Name (HGCAL) into PR title? Thanks

@ebrondol ebrondol changed the title Introduce extend flag Introduce extend flag in HGCal validation Dec 16, 2020
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d25d5f/11753/summary.html
CMSSW: CMSSW_11_3_X_2020-12-16-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747311
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2747282
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 829e206 into cms-sw:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants