Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT subtables after the migration to EOS #32514

Merged
merged 1 commit into from Dec 17, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 17, 2020

PR description:

Update the ConfDB subtables creation script following the migration of the repository from AFS to EOS:

  • fix a bug that prevented using the JAR files in-place;
  • update the curl command to follow redirects when downloading the JAR files over the web.

PR validation:

Creation of ConfDB subtables works again.

Update the ConfDB subtables creation script following the migration of the
repository from AFS to EOS:
  - fix a bug that prevented using the JAR files in-place;
  - update the curl command to follow redirects when downloading the JAR files
    over the web.
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2020

type bug-fix

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2020

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32514/20460

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20b47f/11763/summary.html
CMSSW: CMSSW_11_3_X_2020-12-16-2300/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20b47f/11763/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20b47f/11763/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747239
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 2747186
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 474.891 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 162.715 KiB MTD/ETL
  • DQMHistoSizes: changed ( 23234.0,... ): -4.418 KiB MTD/GlobalReco
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1e4db77 into cms-sw:master Dec 17, 2020
@fwyzard fwyzard deleted the update_subtables_113x branch December 21, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants