Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC [11_2_X] #32532

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This is a backport of PR #32513.

Since PR #29767, which was merged in the 11_1_X series, the EMTF emulator has been configured using the global tag. However, the tags contained in the 2017, 2018, Run 3 or Phase-2 MC specified the incorrect firmware version. This PR updates the tags for L1TMuonEndCapParamsRcd as follows:

  • 2017: L1TMuonEndCapParams_Stage2v1
  • 2018, Run 3 and Phase 2: L1TMuonEndCapParams_Stage2v3_2018_HI_mc

In particular, despite the "HI" in the 2018 MC string, this is indeed the correct tag for pp collisions as well.

More detail can be found at https://indico.cern.ch/event/983008/#41-l1t-emtf-tag-for-run3-mc-gt.

The GT diffs are as follows:

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_design_v1/112X_mc2017_design_v2

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_realistic_v3/112X_mc2017_realistic_v4

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_deco_v3/112X_mc2017cosmics_realistic_deco_v4

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_peak_v3/112X_mc2017cosmics_realistic_peak_v4

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_design_v3/112X_upgrade2018_design_v4

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v6/112X_upgrade2018_realistic_v7

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v6/112X_upgrade2018_realistic_HI_v7

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v6/112X_upgrade2018_realistic_HEfail_v7

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v6/112X_upgrade2018cosmics_realistic_deco_v7

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v6/112X_upgrade2018cosmics_realistic_peak_v7

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v11/112X_mcRun3_2021_design_v12

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v13/112X_mcRun3_2021_realistic_v14

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v13/112X_mcRun3_2021cosmics_realistic_deco_v14

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v13/112X_mcRun3_2021_realistic_HI_v14

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v13/112X_mcRun3_2023_realistic_v14

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v13/112X_mcRun3_2024_realistic_v14

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun4_realistic_v4/112X_mcRun4_realistic_v5

PR validation:

L1T experts have confirmed that this is the tag contains the correct firmware version and that the comparison tests in PR #32513 are expected. In addition, the following technical tests were performed:

addOnTests.py -j 8
runTheMatrix.py -l limited,10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR #32513. It is a bug fix for the incorrect firmware specified in the L1TMuonEndCapParams tag.

@christopheralanwest
Copy link
Contributor Author

backport #32513

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

type bug-fix

@christopheralanwest
Copy link
Contributor Author

test parameters

  • workflow = 10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0e713/11779/summary.html
CMSSW: CMSSW_11_2_X_2020-12-17-1100/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0e713/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 335
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529261
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 18, 2020

+1

@cmsbuild cmsbuild merged commit 32b6829 into cms-sw:CMSSW_11_2_X Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants