Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini aod from700 #3254

Merged
merged 114 commits into from Apr 29, 2014
Merged

Mini aod from700 #3254

merged 114 commits into from Apr 29, 2014

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Apr 8, 2014

gpetruc and others added 30 commits March 11, 2014 11:49
pruned genParticles and of the pat::Muon content.
pat::Trigger needs much more tuning, now it's 15kb!
…less), pack path names into strings (can be easily unpacked in framework and fwlite). patTrigger now down to 4kb/event, dominated by filter labels.
- Make the PATElectronSlimmer configurable
- Addes slimming of GenJets
- reconfigure MC matching to use the prunedGenParticles and the
  slimmedGenJets, and turn off the embedding.
…r. add btag example config. change packing of nHits
…rom any list of candidates (the mapping between the two is static anyway)
- add lines to the CFG to use PAT tools to compute shifted METs
- add datamembers for storing uncertainties into the pat::MET
- add EDProducer to do the packaging of that
- fix PAT tool that removes MC matching to only affect PATJetProducers
Also:
- by default rekey jet daughters
- add class version to packed candidates
@cmsbuild
Copy link
Contributor

Pull request #3254 was updated. @vadler, @anton-a, @thspeer, @slava77, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2014

The number of line changes here " +4,589 −170" compared to those in #3253 " +4,581 −168" is different. Was it something 71X specific or did some commits get lost in 70X?

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2014

Based on just line-number diffs (not checking per-line diff), the following files were changed differently in 71X compared to 70X. Is it all justified?

  • DataFormats/ParticleFlowCandidate/src/classes.h
  • DataFormats/ParticleFlowCandidate/src/classes_def.xml
  • PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc
  • PhysicsTools/PatAlgos/test/miniAOD/patTuple_mini.py

@arizzi
Copy link
Contributor Author

arizzi commented Apr 22, 2014

the DF package was already containing the RefHolder in 71X wrt 70X
the PATPhotonProducer adapts to getByToken interface of LazyTools in 71X wrt 70X
the py file has different input files (70X vs 71X relvals)

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2014

+1

for #3254 250ea82

tested in CMSSW_7_0_X_2014-04-22-0200
(test area sign704a in a combination of pulls 3165 3254 3273 3394)
including extended tests in few-K particle gun samples, few-hundred dijet, and ttbar with PU.
No regressions observed in monitored RECO quantities,
no differences in all harvested DQM plots for the extended tests (timing module jitter ignored).

@vadler
Copy link

vadler commented Apr 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Apr 29, 2014
@davidlange6 davidlange6 merged commit 9ba4e79 into cms-sw:CMSSW_7_0_X Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants