Improve DD4hep workflow perf, step 4: Improve performance of GeometricDet construction in old DD (DDD) and DD4hep

[ghugo83]

• The old legacy code in GeometricDet constructor (re-used for DD4hep) contains a block parsing information from XMLs.
  If we think about it, all this info is related to sensors: hence once can obviously select these volumes only.

• Use std::string iterators instead of constructing temporary string for constructing std::regex.

NB: It could be that additional selections in the GeometricDet constructor will end up beneficial for Phase 2 DD4hep workflow, to be seen.

Summary of performance gains for step 1 with DD4hep workflow (entire step 1 with all initializations + XML parsing + CMS geo construction, up to event generation).
ZMM, Run3, run on my local (forget lxplus ;p):

• step1: Improve DD4hep workflow perf, step 1: All paths from SpecPar blocks with same name are stacked together #32505: ~205s -> ~140s
• step 2: Improve DD4hep workflow perf, step 2: Remove regex from Phase 1 trackerRecoMaterial.xml #32511: ~140s -> ~85s
• step 3: Improve DD4hep workflow perf, step 3: Also reduced the number of paths (with regex) looped over for HCAL #32540: ~85s -> ~80s
• step 4: this PR: ~80s -> ~75s
• DDD is at ~42 s

@ianna @cvuosalo @civanch

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32544/20498

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afeb7d/11810/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[ghugo83]

NB: This PR can be merged independently of step 3 PR.

[qliphy]

+1