Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DD4hep workflow perf, step 4: Improve performance of GeometricDet construction in old DD (DDD) and DD4hep #32544

Merged
merged 3 commits into from Dec 22, 2020
Merged

Improve DD4hep workflow perf, step 4: Improve performance of GeometricDet construction in old DD (DDD) and DD4hep #32544

merged 3 commits into from Dec 22, 2020

Commits on Dec 18, 2020

  1. Old DD (DDD) + DD4hep: can add a branch statement when getting parame… 

    …ters from XMLs in GeometricDet. Indeed, these parameters are only relevant for sensors volumes anyway! This divides by ~3 or ~4 the total numbers of lookups! Could add further selections for IT versus OT, Phase 1 versus Phase 2, but the most stringent call, from very far, seems to be fv->findSpecPar("TrackerRadLength", "TrackerXi") anyway. Effect on DD4hep Run 3 ZMM step 1 (up to event generator): 80s -> 76s on my local
    @ghugo83
    ghugo83 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    850f967 View commit details
    Browse the repository at this point in the history

  2. Use string iterators

    @ghugo83
    ghugo83 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    891ab59 View commit details
    Browse the repository at this point in the history

  3. Nicer to printout when DetIds are computed too.

    @ghugo83
    ghugo83 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    0663f49 View commit details
    Browse the repository at this point in the history