Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nano modifiers in 112X #32618

Merged
merged 7 commits into from Jan 13, 2021
Merged

Nano modifiers in 112X #32618

merged 7 commits into from Jan 13, 2021

Conversation

mariadalfonso
Copy link
Contributor

backport of #32463

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jan 8, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021 •
edited

A new Pull Request was created by @mariadalfonso for CMSSW_11_2_X.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences
PhysicsTools/NanoAOD

@gouskos, @jordan-martins, @chayanit, @wajidalikhan, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @fgolf, @qliphy, @mariadalfonso, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @swertz, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @slomeo, @lecriste, @gpetruc, @mtosi, @peruzzim, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor Author

please test workflow 136.8523

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb75e4/12025/summary.html
COMMIT: 88f4fb0
CMSSW: CMSSW_11_2_X_2021-01-08-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 146 log files, 36 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor Author

+xpog

@chayanit
Copy link

+1

srimanob
srimanob reviewed Jan 11, 2021
View reviewed changes
Configuration/PyReleaseValidation/python/relval_steps.py Outdated
Comment on lines 462 to 463
Run2018Cpilot={319348: [[1, 100]]}
steps['RunJetHT2018C_nanoULremini']={'INPUT':InputInfo(dataSet='/JetHT/Run2018C-UL2018_MiniAODv2_pilot1-v1/MINIAOD',label='2018C',events=100000,location='STD', ls=Run2018Cpilot)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to use pilot dataset here? Pilot dataset should be removed anyway when processing is done. Please move to real Legacy dataset, and contact PdmV to lock specific block at FNAL or CERN where relvals will run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @chayanit

@srimanob
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb75e4/12220/summary.html
COMMIT: 793827b
CMSSW: CMSSW_11_2_X_2021-01-11-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 146 log files, 36 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor Author

+xpog

@srimanob
Copy link
Contributor

+Upgrade

@chayanit
Copy link

+1

@srimanob srimanob mentioned this pull request Jan 12, 2021
Merged
@silviodonato
Copy link
Contributor

@mariadalfonso could you propagate 793827b to master?

@silviodonato
Copy link
Contributor

+operations

@srimanob
Copy link
Contributor

@mariadalfonso could you propagate 793827b to master?

Hi @silviodonato
It is merged to master already
#32648

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8555513 into cms-sw:CMSSW_11_2_X Jan 13, 2021
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srimanob srimanob srimanob left review comments

Assignees
No one assigned
Labels
backport-ok fully-signed operations-approved orp-approved pdmv-approved tests-approved upgrade-approved xpog-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mariadalfonso @cmsbuild @chayanit @wajidalikhan @srimanob @silviodonato @santocch