New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the imports in the split configurations #32754
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20909
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/ParameterSet @makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: Python3 #Python3 I found errors: *** Error compiling 'src/FWCore/ParameterSet/python/Config.py'... |
looks like Python 3 removed support for tuple unpacking via PEP 3113 - good job guys |
6062c06
to
375372a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20973
|
Pull request #32754 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
please test |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found errors in the following unit tests: ---> test testFWCoreFrameworkModuleDeletion had ERRORS ---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS ---> test testPhase2PixelNtuple had ERRORS and more ... RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
Expand to see more addon errors ... |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20984
|
Pull request #32754 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
-1 Failed Tests: UnitTests AddOn Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS ---> test unitTestsGroup_1 had ERRORS ---> test unitTestsGroup_4 had ERRORS and more ... AddOn Tests
Comparison SummarySummary:
|
All failures appear to be in the IB already, but I'd prefer one round of tests with the next IB that should clean with at least some of those. |
please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31fce0/12792/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When generating a split configuration, sort the import in each file by section and by module name.
For example, before:
after:
PR validation:
None.