Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct fractional prescale tag in data global tags #32774

Conversation

christopheralanwest
Copy link
Contributor

PR description:

Recently merged PR #32758 contains an incorrect fractional prescale tag for the data GTs. The tag L1TGlobalPrescalesVetosFract_Stage2_v2_hlt has been replaced by L1TGlobalPrescalesVetosFract_Stage2v1_hlt The tags currently differ by only two 2020 MWGR IOVs so no changes are expected in any relval workflow. More importantly, it is L1TGlobalPrescalesVetosFract_Stage2v1_hlt that is updated by the L1T O2O.

The GT diffs are as follows:

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_v2/113X_dataRun2_v3

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HEfail_v2/113X_dataRun2_HEfail_v3

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_relval_v2/113X_dataRun2_relval_v3

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_PromptLike_HI_v2/113X_dataRun2_PromptLike_HI_v3

Run 2 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HLT_relval_v2/112X_dataRun2_HLT_relval_v3

Run 2 HI HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HLT_relval_HI_v1/112X_dataRun2_HLT_relval_HI_v2

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun3_Express_v1/112X_dataRun3_Express_v2

Run 3 data (prompt)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun3_Prompt_v1/112X_dataRun3_Prompt_v2

PR validation:

Explicit confirmation from experts that the tag in this update is the correct one to use: #32741 (comment)

Also, a technical test was performed: runTheMatrix.py limited,136.8642 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but has already been backported as a part of PR #32772.

@christopheralanwest
Copy link
Contributor Author

test parameters

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32774/20936

  • This PR adds an extra 12KB to repository

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05eb58/12609/summary.html
COMMIT: 1a0c5eb
CMSSW: CMSSW_11_3_X_2021-01-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32774/12609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-05eb58/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2752926
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2752903
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • Correct tag confirmed by L1T experts
  • No changes in PR comparison tests, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3293fbb into cms-sw:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants