Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore messages from RTaskArenaWrapper #32782

Merged
merged 2 commits into from Feb 11, 2021

Conversation

Dr15Jones
Copy link
Contributor

PR description:

These messages are just informative not errors. This is needed to allow use of ROOT 6.22.

PR validation:

The code compiles.

These messages are just informative not errors.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32782/20947

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Services

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 2, 2021

@Dr15Jones , looks like (cms-sw/cmsdist#6570 (comment) ) we also need to convert TThreadExecutor::ParallelReduce and TThreadExecutor::ParallelFor warnings to MessageLogger INFO

@makortel
Copy link
Contributor

makortel commented Feb 2, 2021

@Dr15Jones , looks like (cms-sw/cmsdist#6570 (comment) ) we also need to convert TThreadExecutor::ParallelFor and TThreadExecutor::ParallelFor warnings to MessageLogger INFO

I agree (origina of the printouts https://github.com/root-project/root/blob/98ff53015fbf7927c0942d331877022c1e5664c8/core/imt/src/TThreadExecutor.cxx#L146-L151)

@mrodozov
Copy link
Contributor

mrodozov commented Feb 2, 2021

Is it TThreadExecutor::ParallelFor and TThreadExecutor::ParallelReduce ? (it says TThreadExecutor::ParallelFor twice now)

@smuzaffar
Copy link
Contributor

TThreadExecutor::ParallelFor and TThreadExecutor::ParallelReduce , I had updated my comment

"TDecompChol::Solve",
"THistPainter::PaintInit",
"TUnixSystem::SetDisplay",
"TGClient::GetFontByName",
"Inverter::Dinv"}};
"Inverter::Dinv",
"RTaskArenaWrapper"}};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"RTaskArenaWrapper"}};
"RTaskArenaWrapper",
"TThreadExecutor::ParallelReduce",
"TThreadExecutor::ParallelFor"}};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are additional messages dealing with tbb::global_control
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32782/20968

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

Pull request #32782 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@makortel
Copy link
Contributor

makortel commented Feb 2, 2021

FastSim addon failure looks similar to random errors tracked in #24051.

@makortel
Copy link
Contributor

Based on the tests in cms-sw/cmsdist#6632 (comment) and cms-sw/cmsdist#6631 (comment) it seems this PR is sufficient to cover the messages about tbb::global_control. It's probably still useful to test this PR also alone.

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4b948/12834/summary.html
COMMIT: 3847a11
CMSSW: CMSSW_11_3_X_2021-02-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32782/12834/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751742
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 11, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants