-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore messages from RTaskArenaWrapper #32782
Conversation
These messages are just informative not errors.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32782/20947
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Services @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test |
@Dr15Jones , looks like (cms-sw/cmsdist#6570 (comment) ) we also need to convert |
I agree (origina of the printouts https://github.com/root-project/root/blob/98ff53015fbf7927c0942d331877022c1e5664c8/core/imt/src/TThreadExecutor.cxx#L146-L151) |
Is it |
|
"TDecompChol::Solve", | ||
"THistPainter::PaintInit", | ||
"TUnixSystem::SetDisplay", | ||
"TGClient::GetFontByName", | ||
"Inverter::Dinv"}}; | ||
"Inverter::Dinv", | ||
"RTaskArenaWrapper"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"RTaskArenaWrapper"}}; | |
"RTaskArenaWrapper", | |
"TThreadExecutor::ParallelReduce", | |
"TThreadExecutor::ParallelFor"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size of array also needs an update ( https://github.com/cms-sw/cmssw/pull/32782/files#diff-557c0474dee6f7cb096e823325eb929670d9fe68e9ced2ff73fac38bd449e6c5R169 )
These are additional messages dealing with tbb::global_control
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32782/20968
|
Pull request #32782 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
FastSim addon failure looks similar to random errors tracked in #24051. |
Based on the tests in cms-sw/cmsdist#6632 (comment) and cms-sw/cmsdist#6631 (comment) it seems this PR is sufficient to cover the messages about |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4b948/12834/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
These messages are just informative not errors. This is needed to allow use of ROOT 6.22.
PR validation:
The code compiles.