Run3-hcx285 Make use of ESGetToken in CalibCalorimetry/HcalTPG...

[bsunanda]

PR description:

Make use of ESGetToken in CalibCalorimetry/HcalTPG...

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32784/20951

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc modified in PR(s): Access Conditions DB for HCAL Pulse Filtering Weights #32717

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

CalibCalorimetry/HcalTPGEventSetup
CalibCalorimetry/HcalTPGIO

@malbouis, @yuanchao, @christopheralanwest, @jmduarte, @cmsbuild, @rekovic, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-083144/12636/summary.html
COMMIT: ed1b174
CMSSW: CMSSW_11_3_X_2021-02-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32784/12636/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
312.0 step 1
1000.0 step 2
1001.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 1461 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2579163
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2579136
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 143 log files, 37 edm output root files, 34 DQM output files

[yuanchao]

+1

• migrate from deprecated get(handle) to esconsumes with token.
• matrix run wf tests and unit tests all passed
• static build warnings are not part of this PR.

[silviodonato]

ping @cms-sw/l1-l2 (@jmduarte @rekovic )

[bsunanda]

@jmduarte @rekovic @silviodonato Please approve

[silviodonato]

merge @jmduarte @rekovic

[silviodonato]

merge
@jmduarte @rekovic