Remove duplicate label definition

[lecriste]

PR description:

This PR removes a duplication of label definitions. No changes are expected in the output.

PR validation:

runTheMatrix -l limited

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32785/20952

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

SimDataFormats/Associations
Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @hatakeyamak, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0906d8/12642/summary.html
COMMIT: 96171a4
CMSSW: CMSSW_11_3_X_2021-02-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32785/12642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2752926
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2752893
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[civanch]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

A DataFormat package should not depend on Validation package (even on python level). If a dependence between two packages is needed, the dependence should go in the other direction.

Written that, a DataFormat package should not define plugins (e.g. EDProducers). By quick look SimCalorimetry/HGCalAssociatorProducers could be a reasonable place for the producers.

[lecriste]

@makortel thanks for the comment.
By moving the plugin definition into
SimCalorimetry/HGCalAssociatorProducers, can I keep the dependency on Validation package there or shall I still swap the dependency direction?

[makortel]

I think also there the dependence should go by Validation depending on Simulation.