Pr113x L1T Bug fix: uGT emulator of displaced muons

[rekovic]

PR description:

PR 11_3_X
This is a bug fix needed for MWGR: first check if the high value of the unconstrained pT cut-window is valid (i.e. greater than 0), before proceeding to evaluate the cut on unconstrained pT, otherwise the emulation of triggers without unconstrained pT cuts specified will be affected.
There are no changes to output.
This PR does not depend on any externals.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32790/20958

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32790/20958/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32790/20958/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[rekovic]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32790/20959

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TGlobal

@rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

urgent
needed for MWGR

[davidlange6]

is the cout needed?

[rekovic]

nope.

[rekovic]

updating

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32790/20960

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #32790 was updated. @cmsbuild, @rekovic, @jmduarte can you please check and sign again.

[rekovic]

please test

[rekovic]

will make backport to 11_2_X as soon as IB is available.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7ffa/12646/summary.html
COMMIT: cd133e0
CMSSW: CMSSW_11_3_X_2021-02-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32790/12646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2752926
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2752899
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1