Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr113x L1T Bug fix: uGT emulator of displaced muons #32790

Merged
merged 5 commits into from Feb 3, 2021
Merged

Pr113x L1T Bug fix: uGT emulator of displaced muons #32790

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ddd4b2
fixed bug in evaluation of unconstrained pT cut
cavana Feb 1, 2021
beb0c2d
fixed bug in evaluation of unconstrained pT cut
cavana Feb 1, 2021
f46a5ca
fixed bug in evaluation of unconstrained pT cut (and removed cout sta…
cavana Feb 1, 2021
dee0e92
format.
rekovic Feb 2, 2021
cd133e0
Remove cout.
rekovic Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 23 additions & 7 deletions L1Trigger/L1TGlobal/src/MuCondition.cc
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@
*
* \author: Vasile Mihai Ghete - HEPHY Vienna
* Vladimir Rekovic - extend for indexing
*
* Rick Cavanaugh - include displaced muons
*
*/

Expand Down Expand Up @@ -382,12 +382,28 @@ const bool l1t::MuCondition::checkObjectParameter(const int iCondition,
<< "\n\t hwQual = 0x " << cand.hwQual() << "\n\t hwIso = 0x " << cand.hwIso()
<< std::dec << std::endl;

if (!checkThreshold(objPar.unconstrainedPtLow,
objPar.unconstrainedPtHigh,
cand.hwPtUnconstrained(),
m_gtMuonTemplate->condGEq())) {
LogDebug("L1TGlobal") << "\t\t Muon Failed unconstrainedPt checkThreshold " << std::endl;
return false;
if (objPar.unconstrainedPtHigh > 0) // Check if unconstrained pT cut-window is valid
{
if (!checkThreshold(objPar.unconstrainedPtLow,
objPar.unconstrainedPtHigh,
cand.hwPtUnconstrained(),
m_gtMuonTemplate->condGEq())) {
LogDebug("L1TGlobal") << "\t\t Muon Failed unconstrainedPt checkThreshold " << std::endl;
std::cout << "\t\t Muon Failed unconstrainedPt checkThreshold; iCondition = " << iCondition << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the cout needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating

return false;
}
// check impact parameter ( bit check ) with impact parameter LUT
// sanity check on candidate impact parameter
if (cand.hwDXY() > 3) {
LogDebug("L1TGlobal") << "\t\t l1t::Candidate has out of range hwDXY = " << cand.hwDXY() << std::endl;
return false;
}
bool passImpactParameterLUT = ((objPar.impactParameterLUT >> cand.hwDXY()) & 1);
if (!passImpactParameterLUT) // POTENITAL PROBLEM RICK
{
LogDebug("L1TGlobal") << "\t\t l1t::Candidate failed impact parameter requirement" << std::endl;
return false;
}
}

if (!checkThreshold(objPar.ptLowThreshold, objPar.ptHighThreshold, cand.hwPt(), m_gtMuonTemplate->condGEq())) {
Expand Down