Run3-gex52 Take care of issues in the Ecal endcap algorithm for dd4hep

[bsunanda]

PR description:

Take care of issues in the Ecal endcap algorithm for dd4hep

PR validation:

Tested using cfg in SimG4Core/Configuration/test in a special built where dd4hep is built with Geant4 units.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32809/20991

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/EcalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @fabiocos, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cvuosalo]

@bsunanda In the PR description, could you please describe the issues fixed by this PR?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-506131/12695/summary.html
COMMIT: b78a2a5
CMSSW: CMSSW_11_3_X_2021-02-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32809/12695/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2752926
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2752891
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cvuosalo]

This PR still shows this error:

DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolIns Child:eregalgo:ECVFE Valid:NO 
DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolIns Child:eregalgo:ECVFE Valid:NO 
DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolIns Child:eregalgo:ECVFE Valid:NO 
DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolQ Child:eregalgo:ECVFE Valid:NO 
DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolQ Child:eregalgo:ECVFE Valid:NO 
DD4CMS           ERROR +++ Placement FAILED! Parent:eefixed:EECoolQ Child:eregalgo:ECVFE Valid:NO 

[bsunanda]

@cvuosalo The fix works for the SIM step going for both versions of dd4hep library - with units as G4 or as ROOT

[bsunanda]

@cvuosalo @ianna The issue for EB could be something to do with dd4hep. I sent a mail to you regarding that

[civanch]

@cvuosalo , @ianna , if this fix is valid, let us merge it and let us try to understand EB issue and make a new PR. This problem in EB appears after introduction of G4 units, it may be, of course, issue of DD4Hep but my guess it is most probably CMSSW.

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32809/21017

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #32809 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-506131/12722/summary.html
COMMIT: bd20441
CMSSW: CMSSW_11_3_X_2021-02-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32809/12722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751742
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1