Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EcalMustacheSCParameters and EcalSCDynamicDPhiParameters to GTs #32959

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Feb 21, 2021

PR description:

This PR add to the GTs the EcalMustacheSCParameters and EcalSCDynamicDPhiParameters that were originally presented in https://indico.cern.ch/event/977708/contributions/4117978/attachments/2148136/3621264/alcadb_ecal_sc_params_pr32066_20201123.pdf
Note that only the MC and offilne GTs are updated, while the HLT/Express/Prompt GTs are not updated due to the presence of an ESProducer (see these lines ) that would override the contents of the GTs.

EDIT: as @christopheralanwest pointed out the ESProducer would override these two records for all GTs. So no changes are expected in comparison tests for any workflow and a follow-up PR by ECAL experts will disable the relevant ESProducers.

The GT diffs are as follows:

Run 2 startup
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_startup_v1/113X_mcRun2_startup_v2

Run 2 (L1 trigger stage 1)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_l1stage1_v2/113X_mcRun2_asymptotic_l1stage1_v3

2016 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_design_v2/113X_mcRun2_design_v3

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_preVFP_v2/113X_mcRun2_asymptotic_preVFP_v3

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_v2/113X_mcRun2_asymptotic_v3

2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2cosmics_asymptotic_deco_v2/113X_mcRun2cosmics_asymptotic_deco_v3

Run 2 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_HeavyIon_v2/113X_mcRun2_HeavyIon_v3

Run 2 proton-lead
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_pA_v2/113X_mcRun2_pA_v3

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_v3/113X_dataRun2_v4

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HEfail_v3/113X_dataRun2_HEfail_v4

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_relval_v3/113X_dataRun2_relval_v4

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_PromptLike_HI_v3/113X_dataRun2_PromptLike_HI_v4

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_design_v3/113X_mc2017_design_v4

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_realistic_v3/113X_mc2017_realistic_v4

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_deco_v3/113X_mc2017cosmics_realistic_deco_v4

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_peak_v3/113X_mc2017cosmics_realistic_peak_v4

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_design_v3/113X_upgrade2018_design_v4

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_v3/113X_upgrade2018_realistic_v4

2018 Run-dependent MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v1/113X_upgrade2018_realistic_RD_v2

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HI_v3/113X_upgrade2018_realistic_HI_v4

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HEfail_v3/113X_upgrade2018_realistic_HEfail_v4

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_deco_v3/113X_upgrade2018cosmics_realistic_deco_v4

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_peak_v3/113X_upgrade2018cosmics_realistic_peak_v4

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_design_v4/113X_mcRun3_2021_design_v5

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_v4/113X_mcRun3_2021_realistic_v7

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021cosmics_realistic_deco_v5/113X_mcRun3_2021cosmics_realistic_deco_v6

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_HI_v4/113X_mcRun3_2021_realistic_HI_v5

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2023_realistic_v4/113X_mcRun3_2023_realistic_v5

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2024_realistic_v4/113X_mcRun3_2024_realistic_v5

PR validation:

A technical test was performed:
runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0,7.4,11024.2,11224.0,7.21,7.24,10424.0,136.8642,7.22,1325.516 --ibeos -j 9

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, but it will be backported to 112X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32959/21196

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 12024.0,7.23,159.0,12834.0,7.4,11024.2,11224.0,7.21,7.24,10424.0,136.8642,7.22,1325.516

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-291041/13001/summary.html
COMMIT: 7c8303d
CMSSW: CMSSW_11_3_X_2021-02-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32959/13001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-291041/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750958
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor

+1

  • No unexpected changes in comparison tests, as expected. The spurious differences in workflow 11634.911 are seen in other PRs, for example at PPS pixel topology #32868 (comment). I'm not sure if there is an issue for this irreproducibility.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 22, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants