Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32983

mundim · 2021-02-24T13:35:08Z

PR description:

Putting back changes issued in the PR #32765 (in the gen GluGlu gen fragment with updated/corrected SM parameters and insertion of the wf ID in relval_2017.py file) that was accidentally removed.

PR validation:

All validation already done in the PR #32765

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Shortenning a string the wf configuration Adding the GluGluTo2Jets (for PPS) wfs into relval_2017 config file Reordering the wf number and description in relval_2017.py Updating/correcting SM value in the glugluTo2jet gen fragment correcting a missing comma in the list of wf ids correcting a misplaced comma Changing the wf number as requested in the PR 32765

cmsbuild · 2021-02-24T13:42:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32983/21234

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Generator/python/GluGluTo2Jets_M_300_2000_14TeV_Exhume_cff.py modified in PR(s): Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - Pixel workflows (12/N) #31854

cmsbuild · 2021-02-24T13:42:55Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2021-02-24T13:55:03Z

please test

silviodonato · 2021-02-24T14:22:32Z

abort

silviodonato · 2021-02-24T14:22:55Z

please test workflows 11725.0,11925.0

silviodonato · 2021-02-24T14:23:11Z

test parameters:

workflows = 11725.0,11925.0

cmsbuild · 2021-02-24T18:32:16Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cd059/13062/summary.html
COMMIT: c3fe84a
CMSSW: CMSSW_11_3_X_2021-02-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32983/13062/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11725.0DAS Error
11925.0DAS Error

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0cd059/11725.0_GluGluTo2Jets_14TeV+2021+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0cd059/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

No significant changes to the logs found
Reco comparison results: 1058 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 1571
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2749390
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

silviodonato · 2021-02-25T14:47:46Z

please test
@cms-sw/pdmv-l2 @cms-sw/generators-l2 @cms-sw/upgrade-l2
Do you have any comment?
The differences should be unrelated to this PR.
The errors are expected, we will need to generate the new GEN-SIM for runTheMatrix once this PR is merged (@cms-sw/pdmv-l2)

chayanit · 2021-02-25T17:38:21Z

+1
OK

agrohsje · 2021-02-25T17:46:33Z

No objections.
+1

agrohsje · 2021-02-25T17:58:21Z

+generators

cmsbuild · 2021-02-25T18:46:22Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cd059/13091/summary.html
COMMIT: c3fe84a
CMSSW: CMSSW_11_3_X_2021-02-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32983/13091/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11725.0DAS Error
11925.0DAS Error

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0cd059/11725.0_GluGluTo2Jets_14TeV+2021+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0cd059/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

No significant changes to the logs found
Reco comparison results: 2860 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 63390
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2687571
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

srimanob · 2021-02-25T18:56:34Z

+Upgrade

cmsbuild · 2021-02-25T18:56:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-02-26T01:26:12Z

+1

qliphy · 2021-02-26T01:27:13Z

merge

chayanit · 2021-02-28T16:12:32Z

Why the new workflow is not added here in this PR? @mundim https://github.com/CTPPS/cmssw/blob/66dad2191b4ed343b447b14c983e4eb0752b2345/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1355

qliphy · 2021-02-28T16:37:07Z

Why the new workflow is not added here in this PR? @mundim https://github.com/CTPPS/cmssw/blob/66dad2191b4ed343b447b14c983e4eb0752b2345/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1355

This was added by #32868

mundim · 2021-03-01T21:45:53Z

Hi @chayanit, @silviodonato , others
Sorry for not been too responsive in the last couple of weeks. I was really overloaded and trying to to several things at the same time and made some (maybe lot) of mistakes. I really appreciate the help you all have done.

So, do I need to issue a new PR with the correct (and complete) modifications in all related files?
Once again, sorry for any trouble...

qliphy · 2021-03-02T01:01:59Z

@mundim No need to open a new PR for the moment. We need to wait for PdmV to update the GS string in 11_3_X, which will happen not soon.
#33010 (comment)

mundim and others added 4 commits February 24, 2021 12:48

solve conflict

ecedcee

remove duplicated line

a3e62bf

remove duplicated line

c3fe84a

cmsbuild added this to the CMSSW_11_3_X milestone Feb 24, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Feb 24, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2021

silviodonato changed the title ~~Pps rel val gen fragment reb~~ Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing Feb 24, 2021

silviodonato mentioned this pull request Feb 24, 2021

Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765

Closed

cmsbuild added tests-pending and removed tests-started labels Feb 24, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2021

cmsbuild removed the tests-started label Feb 24, 2021

cmsbuild added tests-started and removed tests-rejected labels Feb 25, 2021

cmsbuild added pdmv-approved and removed pdmv-pending labels Feb 25, 2021

cmsbuild added generators-approved and removed generators-pending labels Feb 25, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 25, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Feb 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 26, 2021

cmsbuild merged commit 52a0e17 into cms-sw:master Feb 26, 2021

silviodonato mentioned this pull request Feb 27, 2021

Missing GEN-SIM input file for 11725.0 and 11925.0 #33010

Closed

silviodonato mentioned this pull request Mar 1, 2021

remove PPS workflows 11725.0 and 11925.0 #33020

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32983

Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32983

mundim commented Feb 24, 2021

cmsbuild commented Feb 24, 2021

cmsbuild commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

cmsbuild commented Feb 24, 2021

silviodonato commented Feb 25, 2021

chayanit commented Feb 25, 2021

agrohsje commented Feb 25, 2021

agrohsje commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

srimanob commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

qliphy commented Feb 26, 2021

qliphy commented Feb 26, 2021

chayanit commented Feb 28, 2021

qliphy commented Feb 28, 2021

mundim commented Mar 1, 2021

qliphy commented Mar 2, 2021

Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32983

Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32983

Conversation

mundim commented Feb 24, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 24, 2021

cmsbuild commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

silviodonato commented Feb 24, 2021

cmsbuild commented Feb 24, 2021

RelVals-INPUT

Comparison Summary

silviodonato commented Feb 25, 2021

chayanit commented Feb 25, 2021

agrohsje commented Feb 25, 2021

agrohsje commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

RelVals-INPUT

Comparison Summary

srimanob commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

qliphy commented Feb 26, 2021

qliphy commented Feb 26, 2021

chayanit commented Feb 28, 2021

qliphy commented Feb 28, 2021

mundim commented Mar 1, 2021

qliphy commented Mar 2, 2021