Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable LumiProducer in reco sequences #33024

Merged
merged 1 commit into from Mar 2, 2021

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Mar 1, 2021

PR description:

Removes LumiProducer from reco sequences to move towards concurrent lumi processing from reco side.
Previous reco-related discussions are in #32518.
The comment that initiated this is here: #25090 (comment)

PR validation:

I'm running the following on cmsdev20:
runTheMatrix.py --command="--customise_commands=\"process.options.wantSummary=True\"" -j 12
I expect to find no references to lumiProducer in the logfile summaries.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport is intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33024/21313

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

Configuration/StandardSequences

@silviodonato, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor Author

jpata commented Mar 1, 2021

@cmsbuild please test

@jpata
Copy link
Contributor Author

jpata commented Mar 1, 2021

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6780aa/13168/summary.html
COMMIT: 83eedd8
CMSSW: CMSSW_11_3_X_2021-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33024/13168/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 11725.0DAS Error
  • 11925.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 66 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750959
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jpata
Copy link
Contributor Author

jpata commented Mar 2, 2021

@cmsbuild please test

the necessary workflows succeeded and show that the LumiProducer was removed, but trying to get rid of the unrelated DAS failures

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6780aa/13188/summary.html
COMMIT: 83eedd8
CMSSW: CMSSW_11_3_X_2021-03-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33024/13188/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 70 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750955
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jpata
Copy link
Contributor Author

jpata commented Mar 2, 2021

+reconstruction

FYI @gkrintir @makortel

@qliphy
Copy link
Contributor

qliphy commented Mar 2, 2021

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 2, 2021

+1

@cmsbuild cmsbuild merged commit a96f16e into cms-sw:master Mar 2, 2021
@mmusich
Copy link
Contributor

mmusich commented Mar 3, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants