drop type specs and change deepcopy to clone in TrackingTools #33046

jeongeun · 2021-03-03T04:35:07Z

PR description:

Update the safer syntax for existing parameter :

drop type specifications where the original parameter exists. : 1 file
change deepcopy() to clone() : 3 files

In this PR, 4 files changed. (previous PRs for TrackingTools is PR#32396 )

TrackingTools/GsfTracking 4 file

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

cmsbuild · 2021-03-03T04:40:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33046/21346

This PR adds an extra 16KB to repository

cmsbuild · 2021-03-03T04:40:41Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

TrackingTools/GsfTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @lecriste, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2021-03-03T06:58:54Z

TrackingTools/GsfTracking/python/BwdAnalyticalPropagator_cfi.py

@@ -1,11 +1,11 @@
 import FWCore.ParameterSet.Config as cms

-import copy
+#import copy


This can be removed

@jeongeun you forgot this line

@jeongeun you forgot this line

Thank you Silvio for checking: I missed it
I remove the "+1" while waiting for this (simple) adjustment

perrotta · 2021-03-03T06:59:01Z

TrackingTools/GsfTracking/python/CkfElectronCandidates_cfi.py

@@ -1,7 +1,9 @@
 import FWCore.ParameterSet.Config as cms

-import copy
+#import copy


This can be removed

perrotta · 2021-03-03T06:59:08Z

TrackingTools/GsfTracking/python/CkfElectronTrajectoryBuilder_cfi.py

@@ -1,9 +1,9 @@
 import FWCore.ParameterSet.Config as cms

-import copy
+#import copy


This can be removed

cmsbuild · 2021-03-03T08:55:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33046/21352

This PR adds an extra 16KB to repository

cmsbuild · 2021-03-03T08:55:43Z

Pull request #33046 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2021-03-03T11:26:40Z

please test

cmsbuild · 2021-03-03T16:34:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8844b5/13239/summary.html
COMMIT: c7ddc90
CMSSW: CMSSW_11_3_X_2021-03-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33046/13239/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2865 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 4923
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2746038
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

perrotta · 2021-03-04T15:45:34Z

Technical
Jenkins tests pass with no relevant differences wrt baseline (random differences in 11634.911 are a recent known general issue)

cmsbuild · 2021-03-04T15:45:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-03-05T03:25:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33046/21390

This PR adds an extra 16KB to repository

cmsbuild · 2021-03-05T03:25:33Z

Pull request #33046 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2021-03-05T06:28:27Z

please test

cmsbuild · 2021-03-05T10:13:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8844b5/13288/summary.html
COMMIT: be8dc1e
CMSSW: CMSSW_11_3_X_2021-03-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33046/13288/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8844b5/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8844b5/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

No significant changes to the logs found
Reco comparison results: 3009 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2849195
DQMHistoTests: Total failures: 64892
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2784280
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files

perrotta · 2021-03-05T10:33:08Z

+1

Technical
Jenkins tests pass with no relevant differences wrt baseline (random differences in 11634.911 are a recent known general issue)

cmsbuild · 2021-03-05T10:33:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-03-05T10:42:33Z

+1

drop type specs and change deepcopy to clone in TrackingTools

2ce2268

cmsbuild added this to the CMSSW_11_3_X milestone Mar 3, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 3, 2021

perrotta reviewed Mar 3, 2021

View reviewed changes

minor fix delete copy

c7ddc90

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 3, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 3, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 3, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 4, 2021

cmsbuild added pending-signatures reconstruction-pending and removed fully-signed reconstruction-approved labels Mar 4, 2021

drop copy

be8dc1e

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Mar 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 5, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 5, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 5, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 5, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 5, 2021

cmsbuild merged commit 8317e84 into cms-sw:master Mar 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop type specs and change deepcopy to clone in TrackingTools #33046

drop type specs and change deepcopy to clone in TrackingTools #33046

jeongeun commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

perrotta Mar 3, 2021

silviodonato Mar 4, 2021

perrotta Mar 4, 2021

perrotta Mar 3, 2021

perrotta Mar 3, 2021

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

perrotta commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

perrotta commented Mar 4, 2021 •

edited

cmsbuild commented Mar 4, 2021

cmsbuild commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

perrotta commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

perrotta commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

silviodonato commented Mar 5, 2021

drop type specs and change deepcopy to clone in TrackingTools #33046

drop type specs and change deepcopy to clone in TrackingTools #33046

Conversation

jeongeun commented Mar 3, 2021

PR description:

PR validation:

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

perrotta Mar 3, 2021

Choose a reason for hiding this comment

silviodonato Mar 4, 2021

Choose a reason for hiding this comment

perrotta Mar 4, 2021

Choose a reason for hiding this comment

perrotta Mar 3, 2021

Choose a reason for hiding this comment

perrotta Mar 3, 2021

Choose a reason for hiding this comment

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

perrotta commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

Comparison Summary

perrotta commented Mar 4, 2021 • edited

cmsbuild commented Mar 4, 2021

cmsbuild commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

perrotta commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

Comparison Summary

perrotta commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

silviodonato commented Mar 5, 2021

perrotta commented Mar 4, 2021 •

edited