Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop type specs and change deepcopy to clone in TrackingTools #33046

Merged
merged 3 commits into from Mar 5, 2021
Merged

drop type specs and change deepcopy to clone in TrackingTools #33046

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ce2268
drop type specs and change deepcopy to clone in TrackingTools
jeongeun Mar 3, 2021
c7ddc90
minor fix delete copy
jeongeun Mar 3, 2021
be8dc1e
drop copy
jeongeun Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions TrackingTools/GsfTracking/python/BwdAnalyticalPropagator_cfi.py
View file
Open in desktop
@@ -1,11 +1,11 @@
import FWCore.ParameterSet.Config as cms

import copy
#import copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongeun you forgot this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongeun you forgot this line

Thank you Silvio for checking: I missed it
I remove the "+1" while waiting for this (simple) adjustment

from TrackingTools.GsfTracking.FwdAnalyticalPropagator_cfi import *
#
# "backward" propagator for electrons
#
bwdAnalyticalPropagator = copy.deepcopy(fwdAnalyticalPropagator)
bwdAnalyticalPropagator.ComponentName = 'bwdAnalyticalPropagator'
bwdAnalyticalPropagator.PropagationDirection = 'oppositeToMomentum'

bwdAnalyticalPropagator = fwdAnalyticalPropagator.clone(
ComponentName = 'bwdAnalyticalPropagator',
PropagationDirection = 'oppositeToMomentum'
)
10 changes: 6 additions & 4 deletions TrackingTools/GsfTracking/python/CkfElectronCandidates_cfi.py
View file
Open in desktop
@@ -1,7 +1,9 @@
import FWCore.ParameterSet.Config as cms

import copy
#import copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

from RecoTracker.CkfPattern.CkfTrackCandidates_cfi import *
CkfElectronCandidates = copy.deepcopy(ckfTrackCandidates)
CkfElectronCandidates.TrajectoryBuilderPSet.refToPSet_ = 'CkfElectronTrajectoryBuilder'

CkfElectronCandidates = ckfTrackCandidates.clone(
TrajectoryBuilderPSet = dict(
refToPSet_ = 'CkfElectronTrajectoryBuilder'
)
)
12 changes: 6 additions & 6 deletions TrackingTools/GsfTracking/python/CkfElectronTrajectoryBuilder_cfi.py
View file
Open in desktop
@@ -1,9 +1,9 @@
import FWCore.ParameterSet.Config as cms

import copy
#import copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

from RecoTracker.CkfPattern.CkfTrajectoryBuilder_cfi import *
CkfElectronTrajectoryBuilder = copy.deepcopy(CkfTrajectoryBuilder)
CkfElectronTrajectoryBuilder.propagatorAlong = 'fwdElectronPropagator'
CkfElectronTrajectoryBuilder.propagatorOpposite = 'bwdElectronPropagator'
CkfElectronTrajectoryBuilder.estimator = 'electronChi2'

CkfElectronTrajectoryBuilder = CkfTrajectoryBuilder.clone(
propagatorAlong = 'fwdElectronPropagator',
propagatorOpposite = 'bwdElectronPropagator',
estimator = 'electronChi2'
)
2 changes: 1 addition & 1 deletion TrackingTools/GsfTracking/python/GsfElectronTracking_cff.py
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@
)

from SimTracker.TrackAssociation.trackTimeValueMapProducer_cfi import trackTimeValueMapProducer
gsfTrackTimeValueMapProducer = trackTimeValueMapProducer.clone(trackSrc = cms.InputTag('electronGsfTracks'))
gsfTrackTimeValueMapProducer = trackTimeValueMapProducer.clone(trackSrc = 'electronGsfTracks')

electronGsfTrackingWithTimingTask = cms.Task(electronGsfTrackingTask.copy(),gsfTrackTimeValueMapProducer)
electronGsfTrackingWithTiming = cms.Sequence(electronGsfTrackingWithTimingTask)
Expand Down