Efficiencies of CSC trigger primitives in validation step and clean-up

[dildick]

PR description:

Addition of efficiencies of CSC trigger primitives vs true muon |eta| in validation step (through truth-matching of simtracks to ALCT/CLCT/LCT).

Also, I gave the code a thorough clean-up.

• Added missing titles and labels for histograms
• Fixed bin ranges where necessary
• Changed to more obvious naming of histograms (ending with "_MEXY" instead of a number 1 through 10)
• Filled the existing wire Y and strip X position resolution plots

PR validation:

Tested with a 11_2_0_pre7 single muon relval (/store/relval/CMSSW_11_2_0_pre7/RelValSingleMuPt10/GEN-SIM-DIGI-RAW/112X_mcRun3_2021_realistic_v8-v1/20000/0ED98457-2CEC-924D-AAFC-4F3F705C2DCC.root)

Code can be tested with

cmsRun Validation/MuonCSCDigis/test/runCSCDigiValidation_cfg.py
cmsRun Validation/MuonCSCDigis/test/runCSCDigiHarvesting_cfg.py
cmsRun Validation/CSCRecHits/test/runCSCRecHitValidation_cfg.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @tahuang1991 @ptcox @AFJohan92

[dildick]

A few screenshots of a short run:

(1) an ALCT efficiency plot

(2) an LCT efficiency plot

(3) Histograms end with MEXY

(4) Most histograms were given more appropriate titles and labels

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33086/21408

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/MuonDetId
Validation/Configuration
Validation/MuonCSCDigis

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @apsallid, @HuguesBrun, @Fedespring, @lecriste, @calderona, @ptcox, @rovere, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[dildick]

A few more timing plots (such plots sometimes show up as differences in PR integration tests)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33086/21409

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #33086 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please check and sign again.

[dildick]

@jfernan2 Could you start the tests, please?

[qliphy]

please test

[dildick]

This was from half an hour ago:

135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS Step0-PASSED Step1-PASSED Step2-PASSED  - time date Thu Mar 11 06:07:17 2021-date Thu Mar 11 05:53:30 2021; exit: 0 0 0
1 1 1 tests passed, 0 0 0 failed

[dildick]

5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Thu Mar 11 07:00:28 2021-date Thu Mar 11 06:49:54 2021; exit: 0 0
1 1 tests passed, 0 0 failed

[dildick]

@jfernan2 This should fix the issue with WF 5.1 and 135.4

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94ccb/13450/summary.html
COMMIT: ff51980
CMSSW: CMSSW_11_3_X_2021-03-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33086/13450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2632997
• DQMHistoTests: Total failures: 46
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2632928
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 62253.842 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 3261.549 KiB CSCRecHitsV/CSCRecHitTask
• DQMHistoSizes: changed ( 10024.0,... ): 12.052 KiB MuonCSCDigisV/CSCDigiTask
• DQMHistoSizes: changed ( 23234.0,... ): 25.899 KiB MuonCSCDigisV/CSCDigiTask
• DQMHistoSizes: changed ( 23234.0,... ): 0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 23234.0,... ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[jfernan2]

@dildick there are entries in most of the plots

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-03-10-2300+f94ccb/41648/dqm-histo-comparison-summary.html

but I cannot judge if they are what you expect, could you please have a look? Thanks

[dildick]

I see that some WFs have entries in the CSC digi and rechit occupancy plots. That is good. I also checked those plots with a relval. It was much clearer then. Efficiency plots look mostly empty. Three plots have one bin filled. I guess in that test there was only one true muon in 10 events that went through a CSC chamber and produced digis and stubs.

[dildick]

@AFJohan92 You made a few plots for a relval, right? Can you attach them to this PR for reference?

[civanch]

unhold

[AFJohan92]

@AFJohan92 You made a few plots for a relval, right? Can you attach them to this PR for reference?

Yes, I've attached example plots from each of the categories with filled plots. They were done with 8k events from the following relval: /store/relval/CMSSW_11_2_0_pre7/RelValSingleMuPt10/GEN-SIM-DIGI-RAW/112X_mcRun3_2021_realistic_v8-v1/20000/0ED98457-2CEC-924D-AAFC-4F3F705C2DCC.root

Please let me know if there's anything else I should add.

[jfernan2]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1