Put CSC validation plot titles back in CSCDigiTask

[dildick]

PR description:

In PR #33086, I mistakenly changed plot titles to be only x-axis titles. They should also remain as plot titles. See examples below. I found this after inspecting the comparison plots in the 11_3_0_pre5_phase2 validation campaign. See also https://tinyurl.com/yghes5ry.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

FYI @ptcox

[dildick]

Some comparisons cannot be made (yet), because I changed the histogram name itself. Histograms ending with "Type" will now end in "_MEXY" specific to each station.

But this is a good example where both the title and binning are ok.

In any case, this should all looking okay by the next relval campaign (11_3_0_pre6, 11_3_0_pre6_phase2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33353/21939

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Validation/MuonCSCDigis

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa93f/14063/summary.html
COMMIT: 772712f
CMSSW: CMSSW_11_3_X_2021-04-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33353/14063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2640845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

@dildick are these labels only present in Online DQM plots? I see no changes in Offline

[dildick]

The content of the plots should be the same, but some titles should have changed. Would this have been picked up by the bot?

[jfernan2]

You are right, since not even binning has changed we are blind to those changes, sorry.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

My bad, I should have clarified. Yeah, this PR (and #33086) is mainly to ease the interpretation of validation plots. Thanks for signing off.

[qliphy]

+1