Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DD4Hep workflow to accept all Run-3 and Phase-2 wfs. Add README.md to runTheMatrix #33087

Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 6, 2021

PR description:

Currently, DD4Hep upgrade workflows accept only TTbar, ZMM, SingleMu gun. This PR is to enable it for all Run-3, Phase-2 workflows for future validation purpose.

In addition, README is added, to document runTheMatrix. The first version is to list all offset we use for upgrade workflows.

PR validation:

runTheMatrix.py --what upgrade -l 11635.911 --wm init dump properly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no need of backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33087/21410

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2021

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2021

Please test

@chayanit
Copy link

chayanit commented Mar 6, 2021

@srimanob thanks a lot! The README.md looks good to me. I think we should try to control and fill the missing ones (e.g. .14, .16 etc) before the numbers get expanded to more digits. What do you think?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a029c/13310/summary.html
COMMIT: 244440a
CMSSW: CMSSW_11_3_X_2021-03-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33087/13310/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1a029c/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1a029c/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 6, 2021

@srimanob I propose merging this first, then I will rebase #33037 and update the README for the new workflows.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 7, 2021

+Upgrade

Thanks very much @kpedro88
@chayanit Is this PR OK for PdmV?

@chayanit
Copy link

chayanit commented Mar 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 7, 2021

+1

@qliphy qliphy merged commit 4adab38 into cms-sw:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants