Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles, fix typo and add source_only flags to fix warnings #33143

Merged
merged 1 commit into from Mar 16, 2021
Merged

Clean BuildFiles, fix typo and add source_only flags to fix warnings #33143

merged 1 commit into from Mar 16, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #33019).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added.

More importantly, it also adds the source_only="1" flag when there are dependencies on source-only packages that have no BuildFiles themselves. Otherwise, we get a warning. We had the same situation with FWCore/SOA (see #31459 (comment)). I just noticed it because even thought missing this flag results in only a warning with scram, it causes my experimental CMSSW Arch linux package to not compile.

This PR further fixes a typo I made in the previous PR #33019.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33143/21508

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibMuon/DTCalibration
DQM/GEM
DQM/SiStripMonitorSummary
DataFormats/DTDigi
DataFormats/HLTReco
GeneratorInterface/LHEInterface
Geometry/VeryForwardGeometry
L1Trigger/L1CaloTrigger
RecoLocalTracker/SiPixelClusterizer
RecoTracker/TkSeedGenerator
SimDataFormats/CrossingFrame
SimDataFormats/DigiSimLinks
SimPPS/PPSPixelDigiProducer

@SiewYan, @andrius-k, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @mkirsano, @kmaeshima, @christopheralanwest, @srimanob, @rvenditti can you please review it and eventually sign? Thanks.
@jhgoh, @felicepantaleo, @forthommel, @abbiendi, @Martin-Grunewald, @OzAmram, @fioriNTU, @alberto-sanchez, @threus, @mmusich, @cericeci, @venturia, @hdelanno, @battibass, @makortel, @JanFSchulte, @watson-ij, @dgulhan, @apsallid, @HuguesBrun, @ferencek, @trocino, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @idebruyn, @ebrondol, @mtosi, @fabiocos, @arossi83, @mkirsano, @jan-kaspar, @Fedespring, @calderona, @dkotlins, @lecriste, @gpetruc, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-898a9c/13437/summary.html
COMMIT: 3e0526a
CMSSW: CMSSW_11_3_X_2021-03-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33143/13437/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@agrohsje
Copy link

+generators

@jfernan2
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Mar 15, 2021

+1

@rekovic
Copy link
Contributor

rekovic commented Mar 16, 2021

+1

@srimanob
Copy link
Contributor

+Upgrade

@SiewYan
Copy link
Contributor

SiewYan commented Mar 16, 2021

+1

@guitargeek
Copy link
Contributor Author

HI @yuanchao, is it okay for you to approve this PR? Thanks!

@christopheralanwest
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 16, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet