New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean BuildFiles, fix typo and add source_only flags to fix warnings #33143
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33143/21508
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CalibMuon/DTCalibration @SiewYan, @andrius-k, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @mkirsano, @kmaeshima, @christopheralanwest, @srimanob, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-898a9c/13437/summary.html Comparison SummarySummary:
|
+generators |
+1 |
+1 |
+1 |
+1 |
+Upgrade |
+1 |
HI @yuanchao, is it okay for you to approve this PR? Thanks! |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Another quick BuildFile cleaning PR in the style of many before (for example #33019).
This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added.
More importantly, it also adds the
source_only="1"
flag when there are dependencies on source-only packages that have no BuildFiles themselves. Otherwise, we get a warning. We had the same situation with FWCore/SOA (see #31459 (comment)). I just noticed it because even thought missing this flag results in only a warning with scram, it causes my experimental CMSSW Arch linux package to not compile.This PR further fixes a typo I made in the previous PR #33019.
PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.