Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Phase2 tracker T25 and T26 (for IT sensor technology studies) #33222

Merged
merged 12 commits into from Mar 22, 2021

Conversation

adewit
Copy link
Contributor

@adewit adewit commented Mar 19, 2021

PR description:

This PR introduces two new phase-2 Tracker layouts proposed with the IT sensors performance Task Force. They correspond to an updated evaluation of the area of the Inner Tracker that can be instrumented with 3D sensors (see https://indico.cern.ch/event/988838/contributions/4258167/attachments/2202703/3736635/em20210305.pdf).

This was mentioned previously in: #33064 (comment)

This introduces:

  • T25, a Tracker based on T21, with 25x100 um2 3D pixels in Inner Tracker TBPX Layer1 and 25x100 um2 planar pixels elsewhere.
  • T26, a Tracker based on T21, with 25x100 um2 3D pixels in Inner Tracker TBPX Layer1, 25x100 um2 planar pixels in TBPX Layer2, Layer3, Layer4 and 50x50 um2 pixels in TFPX and TEPX.

There are no changes in the OT wrt T21

T25:
Geometry scenario: 2026D80.
Workflows: 36[2|3]xx (no PU), 36[4|5]xx (PU).

T26:
Geometry scenario: 2026D81.
Workflows: 36[6|7]xx (no PU), 36[8|9]xx (PU).

PR validation:

  • Checked XMLs make sense from Tracker design point of view
  • Checked overlaps with Fireworks
  • Checked workflow numbering
  • Checked that workflows with scenarios D80 and D81 run smoothly with no extra errors / warnings

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

@emiglior @mmusich @tsusa FYI

@adewit
Copy link
Contributor Author

adewit commented Mar 19, 2021

Marco's comments on an earlier version of the diff (pre- PR) were implemented, but the conversations can't be marked as resolved.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33222/21665

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @adewit for master.

It involves the following packages:

Configuration/AlCa
Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
RecoLocalTracker/SiPixelRecHits

@chayanit, @wajidalikhan, @ianna, @kpedro88, @tlampen, @pohsun, @perrotta, @civanch, @yuanchao, @makortel, @srimanob, @cmsbuild, @davidlange6, @Dr15Jones, @cvuosalo, @mdhildreth, @slava77, @jpata, @qliphy, @fabiocos, @francescobrivio, @malbouis, @jordan-martins, @christopheralanwest, @silviodonato, @franzoni can you please review it and eventually sign? Thanks.
@felicepantaleo, @ghugo83, @Martin-Grunewald, @OzAmram, @threus, @mmusich, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @dgulhan, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @dkotlins, @lecriste, @gpetruc, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 19, 2021

test parameters:

  • workflows = 36234.0, 36634.0

@mmusich
Copy link
Contributor

mmusich commented Mar 19, 2021

@cmsbuild, please test

@srimanob
Copy link
Contributor

+Upgrade

This PR is to add new geometry, with no change on existing geometries, code.

@chayanit
Copy link

+1

@francescobrivio
Copy link
Contributor

+alca

  • adds new geometries (T25,T26) and leaves untouched the already existing ones

@silviodonato
Copy link
Contributor

+operations

@jpata
Copy link
Contributor

jpata commented Mar 22, 2021

+reconstruction

  • no observed reco changes
  • minimal code changes in reco (PixelCPEGeneric and phase2_3DPixels modifiers for PixelCPEGenericESProducer)

@civanch
Copy link
Contributor

civanch commented Mar 22, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 23fad57 into cms-sw:master Mar 22, 2021
@mmusich
Copy link
Contributor

mmusich commented Mar 22, 2021

thanks @silviodonato!

@emiglior
Copy link
Contributor

thanks indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants