Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessors for CLCT and LCT BX as defined in RAW data [11_3_X] #33335

Merged
merged 1 commit into from Apr 8, 2021
Merged

Accessors for CLCT and LCT BX as defined in RAW data [11_3_X] #33335

merged 1 commit into from Apr 8, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 5, 2021

PR description:

Get 2-bit CLCT BX and 1-bit LCT BX as defined in RAW data. Needed for data vs emulator studies in Run-3 L1T DQM. Same numbers as defined in CSCTMBHeader2013::bits::clct_bxn and CSCTMBHeader2013::bits::MPC_Muon0_bx_.

PR validation:

Code compiles. Checked the DQM plots on top of #33085 (WF 12434.0)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Needs to be back-ported to 11_2_X to be used in upcoming global runs.

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33335/21891

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2021

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da7dc3/14008/summary.html
COMMIT: 052c04a
CMSSW: CMSSW_11_3_X_2021-04-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33335/14008/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640868
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640839
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@dildick dildick changed the title Accessors for CLCT and LCT BX as defined in RAW data Accessors for CLCT and LCT BX as defined in RAW data [11_3_X] Apr 7, 2021
@civanch
Copy link
Contributor

civanch commented Apr 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 642217b into cms-sw:master Apr 8, 2021
@dildick
Copy link
Contributor Author

dildick commented Apr 8, 2021

Thanks!

@dildick dildick deleted the from-CMSSW_11_3_X_2021-04-01-2300-CSC-BX-data-v2 branch April 8, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants