Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex64 Make a scenario with V14 version of HGCal and HFNose #33343

Merged
merged 1 commit into from Apr 9, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 6, 2021

PR description:

Make a scenario with V14 version of HGCal, T21 version of Tracker, M9 version of Muons, I13 version of MTD and HFNose

PR validation:

Use the runTheMatrix test workflow 37034.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33343/21919

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/ForwardCommonData

@civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Apr 6, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65981c/14027/summary.html
COMMIT: 7c8c578
CMSSW: CMSSW_11_3_X_2021-04-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33343/14027/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640868
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 6, 2021

+1

@chayanit
Copy link

chayanit commented Apr 7, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

@mariadalfonso @bsunanda @chayanit
If basically, the central detector is the same between D76 and the new D82, except for the addition of HFNose, would it be better to move relvals to D82 instead? As central is the same, it should have no effect on the validation result so far.

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

please test workflow 37034.0

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

please abort

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

@silviodonato @qliphy
I accidentally sign this PR. However, I would like to test with new workflow first. The fist test trigger does not include new geometry test. And I also have the comment for this PR.

@silviodonato
Copy link
Contributor

@silviodonato @qliphy
I accidentally sign this PR. However, I would like to test with new workflow first. The fist test trigger does not include new geometry test. And I also have the comment for this PR.

I deleted your comment, and it seems to work

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

@bsunanda
If this will replace the old HFNose D60, should it be replaced also in the short matrix?
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L91

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

please test workflow 37034.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65981c/14087/summary.html
COMMIT: 7c8c578
CMSSW: CMSSW_11_3_X_2021-04-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33343/14087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-65981c/37034.0_TTbar_14TeV+2026D82+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2835 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 3703
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2861781
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 1 / 37 workflows

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2021

+Upgrade

The new D82 workflow runs fine. We can make another PR if we would like to change the short matrix to this one, instead of D60.

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants