Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: direct simulation uses 14 TeV for Run3 #33370

Merged
merged 1 commit into from Apr 8, 2021

Conversation

jan-kaspar
Copy link
Contributor

PR description:

The beam energy is changed to 7 TeV for the "2021" (Run 3) profile of the PPS direct simulation.

This PR is not urgent.

PR validation:

The comparison chart (blue = before, red dashed = with this PR) dirsim_cmp.pdf shows that

  • no change occurs for other than 2021 profiles
  • for 2021 profile
    • the beam energy actually shifts to 7 TeV
    • no other change is observed - this is actually expected since all elements in the simulation change act upon the relative momentum loss of protons, thus the baseline shift doesn't matter.

The PPS direct simulation is not included in any central workflow, thus running matrix tests is not expected to produce any difference.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33370/21960

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

Validation/CTPPS

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a246e8/14107/summary.html
COMMIT: f211152
CMSSW: CMSSW_11_3_X_2021-04-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33370/14107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865471
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2baff3b into cms-sw:master Apr 8, 2021
@jan-kaspar jan-kaspar deleted the pps_dir_sim_14tev branch August 31, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants