Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ctppsProtons from recoCTPPSTask in Run-3 #33266

Merged
merged 1 commit into from Apr 13, 2021

Conversation

silviodonato
Copy link
Contributor

After #33090, we are finally testing GluGluTo2Jets_M_300_2000_14TeV_Exhume (11725.0,11925.0) in the IB tests (#32969). This workflow was added specifically to test the PPS reco (#32765).

Brief summary of the history:

Reverts #32352

@mundim @fabferro @jan-kaspar @cms-sw/alca-l2 @cms-sw/reconstruction-l2

PS. The last open pre-release of 11_3_X is scheduled on April 13.

@silviodonato
Copy link
Contributor Author

test parameters:

  • workflow = 11725.0,11925.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33266/21757

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

RecoPPS/Configuration

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato silviodonato marked this pull request as draft March 25, 2021 09:39
@silviodonato
Copy link
Contributor Author

I'm still getting

----- Begin Fatal Exception 25-Mar-2021 10:31:20 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 1
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Calling method for module CTPPSProtonProducer/'ctppsProtons'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

in step-3 of 11925.0

cmsDriver.py step3 --conditions auto:phase1_2021_realistic --pileup_input das:/RelValMinBias_14TeV/CMSSW_11_3_0_pre4-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM -n 10 --era Run3 --eventcontent RECOSIM,MINIAODSIM,DQM -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO --pileup Run3_Flat55To75_PoissonOOTPU --geometry DB:Extended --filein file:step2.root --fileout file:step3.root --nThreads 4 > step3_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSimINPUT+DigiPU+RecoPU+HARVESTPU+Nano.log 2>&1
(btw. 11725.0 gives no errors)

From @fabferro's comment (#32356 (comment))

As to the issue of the missing record (LHCInfo), we have prepared the proper sqlite file, going to test it and then send it for imlementation in the GT. Sorry for being late.

@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks!

@francescobrivio
Copy link
Contributor

I'm still getting

----- Begin Fatal Exception 25-Mar-2021 10:31:20 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 1
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Calling method for module CTPPSProtonProducer/'ctppsProtons'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

in step-3 of 11925.0

cmsDriver.py step3 --conditions auto:phase1_2021_realistic --pileup_input das:/RelValMinBias_14TeV/CMSSW_11_3_0_pre4-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM -n 10 --era Run3 --eventcontent RECOSIM,MINIAODSIM,DQM -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO --pileup Run3_Flat55To75_PoissonOOTPU --geometry DB:Extended --filein file:step2.root --fileout file:step3.root --nThreads 4 > step3_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSimINPUT+DigiPU+RecoPU+HARVESTPU+Nano.log 2>&1
(btw. 11725.0 gives no errors)

From @fabferro's comment (#32356 (comment))

As to the issue of the missing record (LHCInfo), we have prepared the proper sqlite file, going to test it and then send it for imlementation in the GT. Sorry for being late.

@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks!

Thye most up to date GT for the phase1_2021_realistic conditions in 113X is 113X_mcRun3_2021_realistic_v7 which does not contain the LHCInfo record, that's the reason for the crash I think.
Was the sqlite file mentioned in the comment ever uploaded?

@christopheralanwest
Copy link
Contributor

From @fabferro's comment (#32356 (comment))

As to the issue of the missing record (LHCInfo), we have prepared the proper sqlite file, going to test it and then send it for imlementation in the GT. Sorry for being late.

@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks!

Thye most up to date GT for the phase1_2021_realistic conditions in 113X is 113X_mcRun3_2021_realistic_v7 which does not contain the LHCInfo record, that's the reason for the crash I think.
Was the sqlite file mentioned in the comment ever uploaded?

No. There are only four available tags with record type LHCInfoRcd, none of which are recently modified: https://cms-conddb.cern.ch/cmsDbBrowser/search/Prod/LHCInfo

@slava77
Copy link
Contributor

slava77 commented Apr 5, 2021

From @fabferro's comment (#32356 (comment))

As to the issue of the missing record (LHCInfo), we have prepared the proper sqlite file, going to test it and then send it for imlementation in the GT. Sorry for being late.

@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks!

Thye most up to date GT for the phase1_2021_realistic conditions in 113X is 113X_mcRun3_2021_realistic_v7 which does not contain the LHCInfo record, that's the reason for the crash I think.
Was the sqlite file mentioned in the comment ever uploaded?

No. There are only four available tags with record type LHCInfoRcd, none of which are recently modified: https://cms-conddb.cern.ch/cmsDbBrowser/search/Prod/LHCInfo

@christopheralanwest @mundim @fabferro @jan-kaspar please clarify on the status of having the right LHCInfoRcd in the GT so that the proton reco can be re-enabled.
Thank you.

@christopheralanwest
Copy link
Contributor

From @fabferro's comment (#32356 (comment))

As to the issue of the missing record (LHCInfo), we have prepared the proper sqlite file, going to test it and then send it for imlementation in the GT. Sorry for being late.

@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks!

Thye most up to date GT for the phase1_2021_realistic conditions in 113X is 113X_mcRun3_2021_realistic_v7 which does not contain the LHCInfo record, that's the reason for the crash I think.
Was the sqlite file mentioned in the comment ever uploaded?

No. There are only four available tags with record type LHCInfoRcd, none of which are recently modified: https://cms-conddb.cern.ch/cmsDbBrowser/search/Prod/LHCInfo

@christopheralanwest @mundim @fabferro @jan-kaspar please clarify on the status of having the right LHCInfoRcd in the GT so that the proton reco can be re-enabled.
Thank you.

A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet.

@silviodonato
Copy link
Contributor Author

@mundim @fabferro @jan-kaspar the last open pre-release of 11_3_x is in one week from now.
https://twiki.cern.ch/twiki/bin/view/CMS/CMSSW_11_3_0
It would be great if we manage to include PPS in the 11_3 production

@fabferro
Copy link
Contributor

fabferro commented Apr 6, 2021

A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet.

@malbouis @wpcarvalho : can you help to include LHCInfo in the GT??

@wpcarvalho
Copy link
Contributor

A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet.

@malbouis @wpcarvalho : can you help to include LHCInfo in the GT??

My understand is that it still needs to be tested. However, I can ask it to be included in the GT, as it should have no "side effect" and is a light single payload tag. Please, let me know what AlCaDB experts think of this approach which may facilitate the tests.

@francescobrivio
Copy link
Contributor

A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet.

@malbouis @wpcarvalho : can you help to include LHCInfo in the GT??

My understand is that it still needs to be tested. However, I can ask it to be included in the GT, as it should have no "side effect" and is a light single payload tag. Please, let me know what AlCaDB experts think of this approach which may facilitate the tests.

Hi @wpcarvalho!
I propose that you post an official request on the AlCa HN specifying the tag that you would like to add and the GT to which it should be added. We can provided a temporary GT to be used for tests and eventually updated the offical GT in autoCond.py once we agree that the tests are successful.

@christopheralanwest
Copy link
Contributor

A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet.

@malbouis @wpcarvalho : can you help to include LHCInfo in the GT??

My understand is that it still needs to be tested. However, I can ask it to be included in the GT, as it should have no "side effect" and is a light single payload tag. Please, let me know what AlCaDB experts think of this approach which may facilitate the tests.

Hi @wpcarvalho!
I propose that you post an official request on the AlCa HN specifying the tag that you would like to add and the GT to which it should be added. We can provided a temporary GT to be used for tests and eventually updated the offical GT in autoCond.py once we agree that the tests are successful.

The tag LHCInfo_2021_mc_v1 does not appear to contain correct data for Run 3. If I execute conddb_dump_LHCInfo -t LHCInfo_2021_mc_v1 -c frontier://FrontierProd/CMS_CONDITIONS -s 1, I find the following line:

Energy (GeV): 6500

Run 3 scenarios assume sqrt(s) = 14 TeV so, assuming this value is intended to represent the energy per beam, it should be set to 7000.

@jan-kaspar
Copy link
Contributor

Run 3 scenarios assume sqrt(s) = 14 TeV so, assuming this value is intended to represent the energy per beam, it should be set to 7000.

If 14 TeV is the CMS default, I think, we (PPS) should align with it. @wpcarvalho could you please update the tag? I can take care of providing a 14 TeV profile for the "direct" simulation.

@wpcarvalho
Copy link
Contributor

Sorry, this post went to my Spam folder. Tomorrow (April 8) I will provide a tag with correct energy and post a request in AlCa HN.

@jan-kaspar
Copy link
Contributor

If 14 TeV is the CMS default, I think, we (PPS) should align with it. @wpcarvalho could you please update the tag? I can take care of providing a 14 TeV profile for the "direct" simulation.

For the "direct" simu part, I've just opened #33370 .

@wpcarvalho
Copy link
Contributor

I've just queued the tag LHCInfo_2021_mc_v2 with the correct beam energy and posted a request in the AlCaDB HN for its inclusion in a GT, along with PPSOpticalFunctions_2021_mc_v1, which is also needed for the reco task.

@silviodonato silviodonato marked this pull request as ready for review April 9, 2021 06:58
@silviodonato
Copy link
Contributor Author

test parameters:

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0fd9/14170/summary.html
COMMIT: ae7170c
CMSSW: CMSSW_11_3_X_2021-04-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33266/14170/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 12-Apr-2021 10:43:36 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module TotemTimingDQMSource/'totemTimingDQMSource'
   [2] Using EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule' to make data CTPPSGeometry/'' in record VeryForwardRealGeometryRecord
   [3] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 10:55:37 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module TotemTimingDQMSource/'totemTimingDQMSource'
   [2] Using EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule' to make data CTPPSGeometry/'' in record VeryForwardRealGeometryRecord
   [3] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 10:57:35 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module TotemTimingDQMSource/'totemTimingDQMSource'
   [2] Using EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule' to make data CTPPSGeometry/'' in record VeryForwardRealGeometryRecord
   [3] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 12-Apr-2021 10:45:55 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 10:42:14 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 10:43:26 CEST-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Running EventSetup component CTPPSGeometryESModule/'ctppsGeometryESModule
Exception Message:
CTPPSDetId ctor: Invalid parameters: arm=21 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@jan-kaspar
Copy link
Contributor

test parameters:

I guess that #33404 includes also the new Run3 geometry for PPS. In this case, tests only make sense with #33250.

@christopheralanwest
Copy link
Contributor

test parameters:

I guess that #33404 includes also the new Run3 geometry for PPS. In this case, tests only make sense with #33250.

All three relevant PRs are included in the tests triggered for PR #33404: #33404 (comment)

@jan-kaspar
Copy link
Contributor

test parameters:

I guess that #33404 includes also the new Run3 geometry for PPS. In this case, tests only make sense with #33250.

All three relevant PRs are included in the tests triggered for PR #33404: #33404 (comment)

Right, #33250 was included for tests of #33404, but not for tests in this PR - this is what I wished to say.

@perrotta
Copy link
Contributor

test parameters:

workflow = 11725.0,11925.0
pull_request = #33404, #33250

@perrotta
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

please test
(retry, because tests do not seem to have started)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0fd9/14183/summary.html
COMMIT: ae7170c
CMSSW: CMSSW_11_3_X_2021-04-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33266/14183/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

----- Begin Fatal Exception 12-Apr-2021 17:53:48 CEST-----------------------
An exception of category 'CTPPSGeometry' occurred while
   [0] Processing  Event run: 323775 lumi: 99 event: 111190435 stream: 3
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CTPPSDiamondLocalTrackFitter/'ctppsDiamondLocalTracks'
   [4] Calling method for module CTPPSDiamondRecHitProducer/'ctppsDiamondRecHits'
Exception Message:
Not found detector with ID 2054160384, i.e. subDet=5 arm=0 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 17:53:46 CEST-----------------------
An exception of category 'CTPPSGeometry' occurred while
   [0] Processing  Event run: 325112 lumi: 6 event: 32600 stream: 3
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CTPPSDiamondLocalTrackFitter/'ctppsDiamondLocalTracks'
   [4] Calling method for module CTPPSDiamondRecHitProducer/'ctppsDiamondRecHits'
Exception Message:
Not found detector with ID 2054160384, i.e. subDet=5 arm=0 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 12-Apr-2021 17:53:24 CEST-----------------------
An exception of category 'CTPPSGeometry' occurred while
   [0] Processing  Event run: 323775 lumi: 99 event: 111372621 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CTPPSDiamondLocalTrackFitter/'ctppsDiamondLocalTracks'
   [4] Calling method for module CTPPSDiamondRecHitProducer/'ctppsDiamondRecHits'
Exception Message:
Not found detector with ID 2054160384, i.e. subDet=5 arm=0 station=1 rp=6
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cf0fd9/11725.0_GluGluTo2Jets_14TeV+2021+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+Digi+Reco+HARVEST+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cf0fd9/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1329 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 3704
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2861761
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.703 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@silviodonato
Copy link
Contributor Author

This PR has been included in #33415

@perrotta
Copy link
Contributor

-1
(Now included in #33415, please close this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants