New binning of Run-3 CLCT slope (CCLUT-13)

[dildick]

PR description:

Previously the CLCT slope binning was fixed to ~0.156 from 0 up to 2.5 half-strips / layer in the Run-3 CLCT algorithm. This PR updates the definition so it is always a multiple of 1/8-strip/layer. First 14 bins are 1/8 wide. Last two are 1/4 and 1/2 wide. See also DN-19-059, section 4.8.

Related PR: cms-data/L1Trigger-CSCTriggerPrimitives#5

PR validation:

Code compiles. Tested in CMSSW_11_2_0_pre9 on single muon gun.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A. Run-3 CLCT algorithm not yet deployed at P5.

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@tahuang1991

[dildick]

A few plots are included in DN-19-059 showing the discretization. Examples for ME1/1, ME1/2, ME2/1 and ME2/2 below

With full slope resolution:

With 1(sign)+4(value) -bit slope resolution

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33380/21973

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[dildick]

@jiafulow @abrinke1 @eyigitba PR for the new slope binning.

[civanch]

please test

[cecilecaillol]

+l1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e4571/14125/summary.html
COMMIT: 2a41cea
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33380/14125/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865477
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1