New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

sharmaaash · 2021-04-12T14:34:53Z

PR description:

Samples "TTbarLepton_14 and QQH1252T_14" added.
No additional changes in 'upgradeWorkflowComponents.py' file

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-04-12T14:42:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33409/22046

This PR adds an extra 40KB to repository
Found files with invalid states:
- Configuration/Generator/python/QQH1352T_14TeV_TuneCP5_cfi.py:
  - Added: 7a251cc
  - Deleted: 6ec27ec
- Configuration/Generator/python/QQH1352T_14TeV_TuneCUETP8M1_cfi.py:
  - Added: 03f104b
  - Deleted: e26410a
- Configuration/Generator/python/TTbarLepton_14TeV_TuneCUETP8M1_cfi.py:
  - Added: 03f104b
  - Deleted: 59487bb

cmsbuild · 2021-04-12T14:42:38Z

A new Pull Request was created by @sharmaaash (Ashish Sharma) for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

SiewYan · 2021-04-12T16:30:33Z

please test

cmsbuild · 2021-04-12T19:04:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fe4d/14190/summary.html
COMMIT: 59487bb
CMSSW: CMSSW_11_3_X_2021-04-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33409/14190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2865526
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2865497
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

chayanit · 2021-04-20T08:19:15Z

Hello @cms-sw/generators-l2 , could we have this PR merged before the final 11_3_0 release? together with #33414 , #33433 and #33386 and also #33407 thanks!

agrohsje · 2021-04-20T08:24:35Z

Configuration/Generator/python/TTbarLepton_14TeV_TuneCP5_cfi.py

+        pythia8CP5SettingsBlock,
+        processParameters = cms.vstring(
+            'Top:gg2ttbar = on ',
+            'Top:gg2ttbar = on ',


what is the reason to have this line twice? is this supposed to be qqbar ?

agrohsje · 2021-04-20T08:25:16Z

Configuration/Generator/python/QQH1252T_14TeV_TuneCP5_cfi.py

+                         pythiaHepMCVerbosity = cms.untracked.bool(False),
+                         # put here the cross section of your process (in pb)
+                         crossSection = cms.untracked.double(0.388),
+                         maxEventsToPrint = cms.untracked.int32(3),


Suggest to set to 0 for relval.

Do you mean cross section or which parameter to set to zero?

agrohsje · 2021-04-20T08:27:28Z

Please see my comments on the fragments. About names. Why is it called TTbarLepton ? Instead of QQH1252T I would propose QQToHToTauTau_mh125 or so. The general ending could be TuneCP5_14TeV_pythia8, just to make it easier to understand what is encoded in the fragment.

cmsbuild · 2021-04-26T11:45:33Z

Pull request #33409 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

agrohsje · 2021-04-28T08:21:01Z

@sharmaaash now the top is called higgstotautau. I think you were misreading my comment. :-)
What about:
QQToHToTauTau_mh125_TuneCP5_14TeV_pythia8_cfi.py
TTbarToDilepton_mt172p5_TuneCP5_14TeV_pythia8_cfi.py
Fragments are ok.

…epton_mt172p5_TuneCP5_14TeV_pythia8_cfi.py

…4TeV_pythia8_cfi.py

sharmaaash · 2021-04-28T17:33:31Z

QQToHToTauTau_mh125_TuneCP5_14TeV_pythia8_cfi.py

I made changes.

cmsbuild · 2021-04-28T17:38:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33409/22360

This PR adds an extra 28KB to repository
Found files with invalid states:
- Configuration/Generator/python/TTbarLepton_14TeV_TuneCP5_cfi.py:
  - Added: 7a251cc
  - Deleted: eaa98c2
- Configuration/Generator/python/QQH1252T_14TeV_TuneCP5_cfi.py:
  - Added: ea59118
  - Modified: b38d60a
  - Deleted: 66a3760
- Configuration/Generator/python/QQH1352T_14TeV_TuneCP5_cfi.py:
  - Added: 7a251cc
  - Deleted: 6ec27ec
- Configuration/Generator/python/QQH1352T_14TeV_TuneCUETP8M1_cfi.py:
  - Added: 03f104b
  - Deleted: e26410a
- Configuration/Generator/python/TTbarLepton_14TeV_TuneCUETP8M1_cfi.py:
  - Added: 03f104b
  - Deleted: 59487bb
- Configuration/Generator/python/QQToHToTauTau_mh125_TuneCP5_14TeV_pythia8_cfi.py:
  - Added: eaa98c2, 66a3760
  - Deleted: 398fb5c

cmsbuild · 2021-04-28T17:39:18Z

Pull request #33409 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

agrohsje · 2021-04-28T19:28:33Z

+generators

cmsbuild · 2021-04-28T19:28:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-04-28T22:08:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fe4d/14684/summary.html
COMMIT: 66a3760
CMSSW: CMSSW_12_0_X_2021-04-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33409/14684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877605
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2877581
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

qliphy · 2021-04-28T23:58:09Z

+1

Configuration/Generator/python/QQToHToTauTau_mh125_TuneCP5_14TeV_pythia8_cfi.py

chayanit · 2021-05-11T15:50:03Z

Configuration/Generator/python/TTbarToDilepton_mt172p5_TuneCP5_14TeV_pythia8_cfi.py

@@ -0,0 +1,29 @@
+import FWCore.ParameterSet.Config as cms
+from Configuration.Generator.Pythia8CommonSettings_cfi import *
+from Configuration.Generator.Pythia8CP5Settings_cfi import *


same here
we noticed that this import has a wrong path and failed in production. It should be fixed soon.
from Configuration.Generator.MCTunes2017.PythiaCP5Settings_cfi import *

So do I need to create another PR with the following changes with the replacement ---> from Configuration.Generator.MCTunes2017.PythiaCP5Settings_cfi import *
?

So do I need to create another PR with the following changes with the replacement ---> from Configuration.Generator.MCTunes2017.PythiaCP5Settings_cfi import *
?

Yes, please.

I made following changes and recreate PR:
#33700

agrohsje · 2021-05-11T16:30:07Z

@chayanit You are right. I overlooked this when giving my ok. @qliphy @silviodonato is there a way to include technical checks for python scripts? Or do we always have to ask the person who makes the PR if the script was tested. For more complicated once, like H7 it would be even more likely that such mistakes get not spot when checking by eye. Do we need to rely on local testing or are there alternatives?

silviodonato · 2021-05-11T19:18:52Z

@agrohsje if you can run the fragment using runTheMatrix.py, we can test the fragment in the PR tests. Otherwise we have to rely on the author or GEN group private test.
All PRs are supposed to be tested by the authors. The tests performed should be reported in the section "PR validation:" in the PR description.

agrohsje · 2021-05-11T20:23:20Z

Hi @silviodonato. Ok. So if not mentioned we will double-check. Thanks!

sharmaaash and others added 7 commits April 2, 2021 05:52

new_samples

03f104b

new_samples

8ee645c

new_samplesUpdated

7a251cc

updated

ea59118

Delete QQH1352T_14TeV_TuneCP5_cfi.py

6ec27ec

Delete QQH1352T_14TeV_TuneCUETP8M1_cfi.py

e26410a

Delete TTbarLepton_14TeV_TuneCUETP8M1_cfi.py

59487bb

cmsbuild added this to the CMSSW_11_3_X milestone Apr 12, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Apr 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 12, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2021

cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021

chayanit mentioned this pull request Apr 19, 2021

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Merged

agrohsje reviewed Apr 20, 2021

View reviewed changes

Rename QQToHToTauTau_mh125_TuneCP5_14TeV_pythia8_cfi.py to TTbarToDil…

398fb5c

…epton_mt172p5_TuneCP5_14TeV_pythia8_cfi.py

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 28, 2021

Rename QQH1252T_14TeV_TuneCP5_cfi.py to QQToHToTauTau_mh125_TuneCP5_1…

66a3760

…4TeV_pythia8_cfi.py

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2021

cmsbuild added fully-signed generators-approved tests-started and removed generators-pending pending-signatures tests-pending labels Apr 28, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 28, 2021

cmsbuild merged commit 399dd9e into cms-sw:master Apr 28, 2021

chayanit reviewed May 11, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

sharmaaash commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

SiewYan commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

chayanit commented Apr 20, 2021 •

edited

agrohsje Apr 20, 2021

agrohsje Apr 20, 2021

sharmaaash Apr 24, 2021

agrohsje commented Apr 20, 2021 •

edited

cmsbuild commented Apr 26, 2021

agrohsje commented Apr 28, 2021

sharmaaash commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

agrohsje commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

qliphy commented Apr 28, 2021

chayanit May 11, 2021

sharmaaash May 11, 2021

qliphy May 12, 2021

sharmaaash May 12, 2021

agrohsje commented May 11, 2021

silviodonato commented May 11, 2021

agrohsje commented May 11, 2021

New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

Conversation

sharmaaash commented Apr 12, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

SiewYan commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

Comparison Summary

chayanit commented Apr 20, 2021 • edited

agrohsje Apr 20, 2021

Choose a reason for hiding this comment

agrohsje Apr 20, 2021

Choose a reason for hiding this comment

sharmaaash Apr 24, 2021

Choose a reason for hiding this comment

agrohsje commented Apr 20, 2021 • edited

cmsbuild commented Apr 26, 2021

agrohsje commented Apr 28, 2021

sharmaaash commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

agrohsje commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

Comparison Summary

qliphy commented Apr 28, 2021

chayanit May 11, 2021

Choose a reason for hiding this comment

sharmaaash May 11, 2021

Choose a reason for hiding this comment

qliphy May 12, 2021

Choose a reason for hiding this comment

sharmaaash May 12, 2021

Choose a reason for hiding this comment

agrohsje commented May 11, 2021

silviodonato commented May 11, 2021

agrohsje commented May 11, 2021

chayanit commented Apr 20, 2021 •

edited

agrohsje commented Apr 20, 2021 •

edited