Prep work for the Run-3 GEM-CSC integrated local trigger #33570

dildick · 2021-04-28T19:56:44Z

PR description:

Prep work for the Run-3 GEM-CSC integrated local trigger. This goes together with PR cms-data/L1Trigger-CSCTriggerPrimitives#6.

The lookup tables were organized into CCLUT, GEMCSC and ME11.
- CCLUT: comparator code LUT algorithm that provides better position and bending resolution
- GEMCSC: GEM-CSC integrated trigger
- ME11: ME11 specific LUTs for ALCTs crossing with CLCTs
CSCComparatorCodeLUT renamed to CSCLUTReader so we can reuse it for the GEM-CSC trigger
Helper classes CSCALCTCrossCLCT, GEMInternalCluster and LCTQualityAssignment were added.
- CSCALCTCrossCLCT: class that checks if an ALCT crosses with a CLCT. Not always the case for ME1/1. A lengthy description was added when this class would be used
- GEMInternalCluster: transient container for GEMPadDigiCluster and a coincidence of two GEMPadDigiClusters. We will shortly be doing the GEM-CSC matching based on GEMPadDigiCluster instead of GEMPadDigi and GEMCoPadDigi, like in the firmware. The emulator would no longer decluster into single pads. The GEMInternalCluster will eliminate much of the code duplication that exists now, and nearly all of the horrible function templating.
- LCTQualityAssignment: class that holds the definitions for LCT quality in Run-2 and Run-3. Documented in DN-20-016. Idea is to unload this code from the TMB classes.

PR validation:

Tested with WF 11634.0. There should be no changes to any of the workflows.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-04-28T20:02:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33570/22364

This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33570/22364/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33570/22364/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-04-28T21:08:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33570/22365

This PR adds an extra 44KB to repository

cmsbuild · 2021-04-28T21:08:38Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2021-04-29T07:05:49Z

please test

cmsbuild · 2021-04-29T08:26:20Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d4699/14695/summary.html
COMMIT: 164715f
CMSSW: CMSSW_12_0_X_2021-04-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.8523

----- Begin Fatal Exception 29-Apr-2021 09:26:56 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/PhaseII/PhotonID_MVA_barrel_Egamma_PhaseII_weight.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 29-Apr-2021 09:27:16 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/PhaseII/PhotonID_MVA_barrel_Egamma_PhaseII_weight.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 29-Apr-2021 09:27:16 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/PhaseII/PhotonID_MVA_barrel_Egamma_PhaseII_weight.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14695/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-04-28-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

Expand to see more relval errors ...

dildick · 2021-04-29T16:37:25Z

@cecilecaillol These failures should be go away by restarting the tests. I think a new IB was made that should take care of changes in cms-data.

cecilecaillol · 2021-04-29T17:08:58Z

please test

cmsbuild · 2021-04-29T19:42:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d4699/14711/summary.html
COMMIT: 164715f
CMSSW: CMSSW_12_0_X_2021-04-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14711/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662700
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2662674
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

dildick · 2021-04-29T19:48:56Z

4 failures. 3 from egamma, 1 from pixel

cecilecaillol · 2021-04-30T06:53:23Z

+l1

cmsbuild · 2021-04-30T06:53:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-04-30T07:30:25Z

test parameters

pull_requests = Update of ME1/1 LUTs. GEM-CSC LUTs with M9 GE2/1 geometry cms-data/L1Trigger-CSCTriggerPrimitives#6

qliphy · 2021-04-30T07:30:40Z

please test

cmsbuild · 2021-04-30T10:51:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d4699/14732/summary.html
COMMIT: 164715f
CMSSW: CMSSW_12_0_X_2021-04-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33570/14732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2662617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

dildick · 2021-04-30T12:19:47Z

@qliphy Thanks a lot, in principle the external is not yet needed, as the Run-3 CSC trigger algorithm is not switched on yet. But in a few weeks to months this is certainly the plan.

qliphy · 2021-04-30T12:42:39Z

@qliphy Thanks a lot, in principle the external is not yet needed, as the Run-3 CSC trigger algorithm is not switched on yet. But in a few weeks to months this is certainly the plan.

Thanks @dildick for the information! So we can move forward this PR first.

qliphy · 2021-04-30T12:46:49Z

+1

Sven Dildick added 3 commits April 28, 2021 13:38

Rename class so we can reuse it for the GEM-CSC trigger and ME11 TMB

1436944

LUTs for GEM-CSC ILT. Organize all LUTs in subdirs

6f10501

New helper classes

a3a0e75

cmsbuild added this to the CMSSW_12_0_X milestone Apr 28, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Apr 28, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 28, 2021

Code format

164715f

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 28, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 29, 2021

cmsbuild added tests-rejected and removed tests-started labels Apr 29, 2021

abdoulline mentioned this pull request Apr 29, 2021

Adopt HFSignalAsymmetry flag in HF PFRecHit cleaning #33520

Merged

cmsbuild added tests-started and removed tests-rejected labels Apr 29, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Apr 30, 2021

cmsbuild added requires-external tests-started and removed tests-approved labels Apr 30, 2021

qliphy mentioned this pull request Apr 30, 2021

Update of ME1/1 LUTs. GEM-CSC LUTs with M9 GE2/1 geometry cms-data/L1Trigger-CSCTriggerPrimitives#6

Merged

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 30, 2021

cmsbuild merged commit 6a24449 into cms-sw:master Apr 30, 2021

dildick deleted the from-CMSSW_12_0_X_2021-04-28-1100-GEMCSC-Run3-prep branch May 3, 2021 15:44

dildick mentioned this pull request May 4, 2021

Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

Merged

dildick mentioned this pull request Jul 22, 2021

GEM-CSC Trigger for Run-3 #34582

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prep work for the Run-3 GEM-CSC integrated local trigger #33570

Prep work for the Run-3 GEM-CSC integrated local trigger #33570

dildick commented Apr 28, 2021 •

edited

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cecilecaillol commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

dildick commented Apr 29, 2021

cecilecaillol commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

dildick commented Apr 29, 2021

cecilecaillol commented Apr 30, 2021

cmsbuild commented Apr 30, 2021

qliphy commented Apr 30, 2021

qliphy commented Apr 30, 2021

cmsbuild commented Apr 30, 2021

dildick commented Apr 30, 2021

qliphy commented Apr 30, 2021

qliphy commented Apr 30, 2021

Prep work for the Run-3 GEM-CSC integrated local trigger #33570

Prep work for the Run-3 GEM-CSC integrated local trigger #33570

Conversation

dildick commented Apr 28, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cmsbuild commented Apr 28, 2021

cecilecaillol commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

RelVals

RelVals-INPUT

dildick commented Apr 29, 2021

cecilecaillol commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

Comparison Summary

dildick commented Apr 29, 2021

cecilecaillol commented Apr 30, 2021

cmsbuild commented Apr 30, 2021

qliphy commented Apr 30, 2021

qliphy commented Apr 30, 2021

cmsbuild commented Apr 30, 2021

Comparison Summary

dildick commented Apr 30, 2021

qliphy commented Apr 30, 2021

qliphy commented Apr 30, 2021

dildick commented Apr 28, 2021 •

edited