New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617
Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617
Conversation
Needs to be tested with cms-data/L1Trigger-CSCTriggerPrimitives#6 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33617/22461
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-data/L1Trigger-CSCTriggerPrimitives#6 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f787e7/14827/summary.html Comparison SummarySummary:
|
Pull request #33617 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again. |
please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
|
Hi @cecilecaillol. Thanks for running the tests. Could retry with |
please test with cms-data/L1Trigger-CSCTriggerPrimitives#6 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f787e7/14882/summary.html Found compilation warnings Comparison SummarySummary:
|
11 failures from messagelogger, 1 from pixel |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Thanks @cecilecaillol. |
PR description:
More prep work for the Run-3 GEM-CSC integrated local trigger. This goes together with PR cms-data/L1Trigger-CSCTriggerPrimitives#6. Follow-up of #33570
LCTQualityAssignment
CSCALCTCrossCLCT
In the next PR we will be updating the GEM-CSC matching procedures with 1/2-strip resolution and 1/8-strip resolution. The former is intended to be compatible with Run-2 EMTF. The latter would be compatible with Run-3 EMTF. The CSCUpgradeMotherboardLUT will be deleted (all luts in cms-data). CSCGEMMotherboardME11 and CSCGEMMotherboardME21 will be merged into CSCGEMMotherboard. CSCMotherboardME11 will be merged into CSCUpgradeMotherboard. This will be possible since we don't split up the LCT finding in ME1/a and ME1/b. Sorting and readout functions will be streamlined as well.
PR validation:
Tested with WF 11634.0. There shouldn't be any changes in WFs.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Before submitting your pull requests, make sure you followed this checklist:
@tahuang1991