Cleanup of data/simulation analyzer modules in CSCTriggerPrimitives

[dildick]

PR description:

Following PR #33085, I add a simple analyzer that overlays all data vs emulator histograms and puts the results into a single postscript file for analysis.

The analyzers CSCAnodeLCTAnalyzer, CSCAnodeLCTAnalyzer and CSCTriggerPrimitivesReader are being deprecated. The MC-truth analysis is already contained in Validation/MuonHits and Validation/MuonCSCDigis, and included in the standard release validation sequence. The data vs emulator comparisons are now in DQM/L1TEmulator(Client) and DQM/Integration. The remaining useful pieces will be cannibalized into CSCTriggerPrimitiveAnalyzer.

I added documentation in README.md files so people know how they can use the test configurations.

PR validation:

Tested in CMSSW_12_0_X on a recent run.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22387

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitiveAnalyzer_cfg.py:
    • Added: 033a209
    • Deleted: 54275a1

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5bdd9/14731/summary.html
COMMIT: 095be71
CMSSW: CMSSW_12_0_X_2021-04-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33582/14731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2662623
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[dildick]

A few minor bugfixes. I also added configuration to run the offline DQM locally on a data file from P5. Ultimately it should also work on data from the GEM-CSC trigger test-stand - but that is not working yet.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22407

• This PR adds an extra 24KB to repository

• Found files with invalid states:

  • L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitiveAnalyzer_cfg.py:
    • Added: 033a209
    • Deleted: 54275a1

[cmsbuild]

Pull request #33582 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22413

• This PR adds an extra 16KB to repository

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22479

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/test/BuildFile.xml modified in PR(s): Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22479/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22479/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33582/22480

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/test/BuildFile.xml modified in PR(s): Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

[cmsbuild]

Pull request #33582 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5bdd9/14870/summary.html
COMMIT: 6e9a5e0
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33582/14870/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662611
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1