Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WToLNu and WprimeToLNu genFragments at 14 TeV [backport #33407] #33596

Merged
merged 5 commits into from May 4, 2021

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented May 1, 2021

PR description:

backport of #33407

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2021

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_11_3_X.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented May 2, 2021

assign pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2021

New categories assigned: pdmv

@jordan-martins,@chayanit,@wajidalikhan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@qliphy
Copy link
Contributor

qliphy commented May 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d27b9/14777/summary.html
COMMIT: 9df6af9
CMSSW: CMSSW_11_3_X_2021-05-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33596/14777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented May 3, 2021

+generators

@chayanit
Copy link

chayanit commented May 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 4, 2021

+1

@cmsbuild cmsbuild merged commit defa887 into cms-sw:CMSSW_11_3_X May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants