New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex73 Remove reference of DDD from plugins/dd4hep/DDEcalEndcapAlgo.cc #33600
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33600/22415
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@cvuosalo I have removed reference to old DDD here. Had to retain DDEcalEndcapTrap for the DDD version and use a name DDEcalEndcapTrapX for dd4hep version |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33600/22416
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/EcalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2e279/14779/summary.html Comparison SummarySummary:
|
#include "DetectorDescription/DDCMS/interface/DDTranslation.h" | ||
|
||
// Define Endcap Supercrystal class | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a comment here saying that this file is the DD4hep version that should become the only version when DDD is eliminated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a comment here saying that this file is the DD4hep version that should become the only version when DDD is eliminated.
@bsunanda Would you please add the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qliphy @silviodonato @cvuosalo added the comment in PR description
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda , should this PR be backported? |
@civanch This PR is just clean-up. It doesn't need to be backported. |
+1 |
PR description:
Remove reference of DDD from plugins/dd4hep/DDEcalEndcapAlgo.cc
PR validation:
Use the test script in SimG4Core/Configuration/test
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special