New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtd parameters update for D49 and D60 geometries (Bug fix) #33647
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33647/22523
|
A new Pull Request was created by @parbol for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test minor effects expected |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dc508/14914/summary.html Comparison SummarySummary:
|
@parbol changes as naively expected I would say. The numbers incorrectly used as microns describing a gap were all quite small. |
@fabiocos Yes, I think this is the expected behaviour. |
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This fix was already in #33598 , anyway this can be merged earlier. It would be useful for consistency to get it in 11_3_X in case someone wants to use D49, in order to avoid small but non properly defined differences with earlier versions. |
PR description:
This PR fixes a bug introduced by #33340, affecting the D49 and D60 geometries. That PR reinterpreted the numbers in the BTL and ETL number vectors in the mtdParameters.xml file as interpad/and pad-to-border distances to define the dead areas around the pads, however the change was not made for the mtdParameters.xml being used by the D49 and D60 geometries. This PR updates also those numbers setting the distances as "0" to exactly reproduce the behaviour of the D49 and D60 geometries.