New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise Exception only if there are two workflows having the same name #33732
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33732/22672
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c482cb/15092/summary.html Comparison SummarySummary:
|
test parameters:
|
please test workflow 37725.0 |
-1 Failed Tests: RelVals RelVals
|
please test workflow 37725.0 |
-1 Failed Tests: RelVals RelVals
|
Hi @silviodonato , I'm not sure how we can have duplicate workflows with the same IDs? |
@chayanit this is needed for running multiple matrices in the PR test. The most common case happens when somebody wants to extend the PR test to a workflow that is included |
move to a different solution #33823 |
ah I see thanks @silviodonato |
Premise
When two workflows having the same name are found,
runTheMatrix.py
gives the warning:This happens if you try to run on
runTheMatrix.py --showMatrix --what upgrade,2026
, because2026
is a subset ofupgrade
.The possibility to run on multiple matrices was added by #33338. This PR added also a protection to prevent you from running on a workflow number that is used in multiple workflows.
PR description:
This PR allows you to run on workflow numbers (eg.
23461.97
) which are defined multiple times if and only if the duplicated workflows have the same name (eg.23461.97_PREMIXUP26D49_PU25+2026D49PU_PMXS1+PREMIX_PremixHLBeamSpotPU
)PR validation:
Previous behavior (ERROR if there are wfs defined multiple times)
New behavior (WARNING if there are wfs defined multiple times having the same wf name)
New behavior (ERROR if there are wfs defined multiple times having different wf name)