New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runTheMatrix.py] Adding cleanedupgrade matrix for PR tests #33823
[runTheMatrix.py] Adding cleanedupgrade matrix for PR tests #33823
Conversation
test parameters:
|
please test workflow 37725.0 |
btw. I think this solution was proposed by @fwyzard during a ORP meeting long time ago. |
please abort |
please test workflow 37725.0 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33823/22832
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: RelVals RelVals
|
please test workflow 36216.0 |
|
||
from Configuration.PyReleaseValidation.relval_upgrade import workflows as _upgrade_workflows | ||
|
||
wfAlreadyIncluded = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where wfAlreadyIncluded
is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. I'm fixing it
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33823/22848
|
Pull request #33823 was updated. @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please check and sign again. |
please test workflow 36216.0 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2767ea/15325/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR add a new matrix in runTheMatrix.py that is defined as a copy of the
upgrade
matrix, after having removed all the workflows in common to the other matrices (eg.23461.97
is both is2026
andupgrade
).This PR will allow the PR tests to run
cleanedupgrade
together with the other matrices without problems. In other words, this PR will solve the problems of the duplicated wfs (see #33338 and #33732)PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport needed