Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runTheMatrix.py] Adding cleanedupgrade matrix for PR tests #33823

Merged
merged 3 commits into from May 27, 2021

Conversation

silviodonato
Copy link
Contributor

PR description:

This PR add a new matrix in runTheMatrix.py that is defined as a copy of the upgrade matrix, after having removed all the workflows in common to the other matrices (eg. 23461.97 is both is 2026 and upgrade).
This PR will allow the PR tests to run cleanedupgrade together with the other matrices without problems. In other words, this PR will solve the problems of the duplicated wfs (see #33338 and #33732)

PR validation:

runTheMatrix.py  -l 38132.98,10024.0  --what standard,highstats,pileup,generator,production,ged,2017,2026,machine,cleanedupgrade

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport needed

@silviodonato
Copy link
Contributor Author

test parameters:

  • relvals_options = --what standard,highstats,pileup,generator,production,ged,2017,2026,machine,premix,cleanedupgrade

@silviodonato
Copy link
Contributor Author

please test workflow 37725.0

@silviodonato
Copy link
Contributor Author

btw. I think this solution was proposed by @fwyzard during a ORP meeting long time ago.

@silviodonato
Copy link
Contributor Author

please abort

@silviodonato
Copy link
Contributor Author

please test workflow 37725.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33823/22832

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2767ea/15276/summary.html
COMMIT: 88ea19f
CMSSW: CMSSW_12_0_X_2021-05-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33823/15276/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 24-May-2021 19:55:40 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@silviodonato
Copy link
Contributor Author

please test workflow 36216.0


from Configuration.PyReleaseValidation.relval_upgrade import workflows as _upgrade_workflows

wfAlreadyIncluded = []
Copy link
Contributor

@srimanob srimanob May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where wfAlreadyIncluded is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I'm fixing it

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33823/22848

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33823 was updated. @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please check and sign again.

@silviodonato
Copy link
Contributor Author

please test workflow 36216.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2767ea/15325/summary.html
COMMIT: d0a7442
CMSSW: CMSSW_12_0_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33823/15325/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2767ea/36216.0_SingleGammaPt35Extended+2026D80+DoubleGammaPt35Extended_pythia8_GenSimHLBeamSpot+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@chayanit
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor Author

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants