L1 phase 2: produce CaloJet/Tau (corrected version)

[cecilecaillol]

PR description:

Updated Phase2 L1 CaloJet/Tau code from CMSSW_10_5_0_pre1 release to new data formats in more recent release and added minimum code necessary to produce CaloJets/Taus (L1Trigger/L1CaloTrigger/).

Same as #33612 but I made a github mistake in the other PR, which is closed now.

PR validation:

Same as #33612

if this PR is a backport please specify the original PR and why you need to backport that PR:

Same as #33612

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33750/22696

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • L1Trigger/TrackFindingTracklet/python/L1TrackletTracks_cff.py:
    • Added: 2b5f12a
    • Deleted: 5e7f14c

[cmsbuild]

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

DataFormats/L1TCalorimeterPhase2
L1Trigger/L1CaloTrigger
L1Trigger/Phase2L1ParticleFlow

@cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c1326/15129/summary.html
COMMIT: 41e6e2e
CMSSW: CMSSW_12_0_X_2021-05-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33750/15129/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648219
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33750/22867

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • L1Trigger/TrackFindingTracklet/python/L1TrackletTracks_cff.py:
    • Added: 2b5f12a
    • Deleted: 5e7f14c
  • L1Trigger/L1CaloTrigger/python/test_L1CaloJets_cfg.py:
    • Added: 2b5f12a
    • Modified: 5e7f14c
    • Deleted: ec50927

[cmsbuild]

Pull request #33750 was updated. @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c1326/15319/summary.html
COMMIT: ec50927
CMSSW: CMSSW_12_0_X_2021-05-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33750/15319/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cecilecaillol]

@srimanob Your comments have been addressed

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1