MTD reconstruction: set fixed precision for floating point printed in unit test

[fabiocos]

PR description:

Fix rounding in printout used in unit test of RecoMTD/DetLayers, as the precision is creating issues with alternative architectures (PPC and arm).

PR validation:

Code runs, rounding at 4 decimal digits allows check of positions at micron level. To be verified on alternative architectures.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33762/22713

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoMTD/DetLayers/test/TestETLNavigation.cc modified in PR(s): update deepCore for Run3 #33531

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

RecoMTD/DetLayers

@perrotta, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with cms-data/Geometry-TestReference#9

initial test with default architecture

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c380/15150/summary.html
COMMIT: a9c5bfa
CMSSW: CMSSW_12_0_X_2021-05-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33762/15150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648213
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[fabiocos]

the tests in cms-data/Geometry-TestReference#9 show this rounding protects the unit test on other architectures, namely slc7_ppc64le_gcc9 and slc7_aarch64_gcc9

[mrodozov]

+externals

[perrotta]

+1

• It fixes a failure of the RecoMTDDetLayersTestDriver test, which started failing for both PPC and Arm after it was added in MTD geometry and reconstruction: store ETL layout logic into MTDTopology, use for ETL layers navigation in reconstruction #33598
• Tested also in Reference file for the unit test of RecoMTD/DetLayers with rounding at 4 decimal digits cms-data/Geometry-TestReference#9 in several architectures, see MTD reconstruction: set fixed precision for floating point printed in unit test #33762 (comment)
• Jenkins tests pass, with no differences in the standard workflows, as expected because only some different rounding in the printouts was added

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1