Modification to PythiaFilterMotherSister #33806

mgratti · 2021-05-21T10:54:28Z

This PR modifies the PythiaFilterMotherSister, which is a generator filter introduced in #33308 , designed to
efficiently select events with heavy long-lived neutrinos a B semi-leptonic decay.

The modifications are:

2D displacement of the long-lived particle is used instead of 3D displacement
the possibility to cut on the pt of the decay products of the long-lived particle is added.

This PR will be followed by a backport in 10_2_X.

… displacement

cmsbuild · 2021-05-21T11:01:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/22795

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-21T11:02:05Z

A new Pull Request was created by @mgratti (Maria Giulia Ratti) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

agrohsje · 2021-05-21T19:09:30Z

GeneratorInterface/GenFilters/plugins/PythiaFilterMotherSister.cc

+                if (nephew_pdgId == 11 or nephew_pdgId == 13 or nephew_pdgId == 15)
+                  passLeptonPt = ((*nephew)->momentum().perp() > minLeptonPt);
+                if (nephew_pdgId == 211)
+                  passTrackPt = ((*nephew)->momentum().perp() > minTrackPt);


What happens if you have multiple? With the current logic the last one need to be above. Is this what you had in mind? or do you mean "implicit assumption"?

If the decay products of the sister particle include more than one lepton, only the last one will be checked.
For my use case, this is irrelevant because by construction only one of the decay products will be a lepton.

The code can be easily generalised to the case where multiple charged leptons/pions are present and all of them are required to pass the specified pt cuts. @agrohsje, please, let me know your preference.

i would prefer moving to the generalized setup. @qliphy @silviodonato what do you think?

A generalized setup is fine to me.

Ok, thanks. The update will come tomorrow. We've had downtime at our t3 in the last two days.

Thanks so much Maria!

…e leptons and tracks

cmsbuild · 2021-05-28T15:06:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/22918

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-28T15:06:34Z

Pull request #33806 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

SiewYan · 2021-05-28T15:15:27Z

please test

cmsbuild · 2021-05-28T18:19:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc445/15392/summary.html
COMMIT: 277911e
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33806/15392/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

agrohsje · 2021-06-01T19:11:44Z

GeneratorInterface/GenFilters/plugins/PythiaFilterMotherSister.cc

+                if (minLeptonPt > 0. and (nephew_pdgId == 11 or nephew_pdgId == 13 or nephew_pdgId == 15))
+                  failLeptonPt += ((*nephew)->momentum().perp() < minLeptonPt);
+                if (minTrackPt > 0. and nephew_pdgId == 211)
+                  failTrackPt += ((*nephew)->momentum().perp() < minTrackPt);
+              }


Hi Maria. Let me understand. Why is 11,13 and 15 generic. I know it is called lepton pT, but does this cover all needs. Even more about the pion. Can you clarify why this can be hard-coded?

Hi, are you asking if the current logic covers all possible decay products of the sister particle? If so, not all possible cases are covered; this is ok for my specific case. In order to make this more general, I could implement the pdgid(s) of the nephew particle(s) as parameters, in addition to the corresponding pts. Please, let me know if this option is ok for you or if you had in mind something different.

Right. That was my proposal: I would add them as steerable parameters. Thanks!

mgratti · 2021-06-03T07:35:47Z

@agrohsje, perhaps you missed my reply above? Could you please merge or propose changes, so that we can converge on this and the respective backports?

cmsbuild · 2021-06-03T15:57:54Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/23056

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/23056/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/23056/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-06-03T16:11:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33806/23058

This PR adds an extra 20KB to repository

cmsbuild · 2021-06-03T16:12:21Z

Pull request #33806 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

mgratti · 2021-06-06T10:11:45Z

hi @agrohsje , the proposed changes were implemented. Would it be possible to go ahead with this PR? Thank you!

SiewYan · 2021-06-07T13:36:30Z

please test

cmsbuild · 2021-06-07T16:42:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc445/15716/summary.html
COMMIT: e7adc04
CMSSW: CMSSW_12_0_X_2021-06-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33806/15716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648335
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2648312
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

agrohsje · 2021-06-08T10:47:51Z

+generators

cmsbuild · 2021-06-08T10:48:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-08T11:17:48Z

+1

added possibility to cut on pt of the nephews and moved from 3D to 2D…

b560706

… displacement

cmsbuild added this to the CMSSW_12_0_X milestone May 21, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels May 21, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2021

mgratti mentioned this pull request May 21, 2021

[backport] Modification to PythiaFilterMotherSister #33815

Merged

agrohsje reviewed May 21, 2021

View reviewed changes

while checking pt of decay products of sister particle, allow multipl…

277911e

…e leptons and tracks

cmsbuild added code-checks-pending and removed code-checks-approved labels May 28, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2021

cmsbuild added tests-started and removed tests-pending labels May 28, 2021

cmsbuild added tests-approved and removed tests-started labels May 28, 2021

mgratti mentioned this pull request Jun 1, 2021

[backport] Added new filter, thought for a B -> l HNL X analysis #33926

Merged

agrohsje reviewed Jun 1, 2021

View reviewed changes

ids and pts are now configurable parameters

4322712

cmsbuild added code-checks-pending tests-pending labels Jun 3, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 3, 2021

code style

e7adc04

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 3, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 7, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 7, 2021

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jun 8, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 8, 2021

cmsbuild merged commit 47ff64d into cms-sw:master Jun 8, 2021

cmsbuild mentioned this pull request Jun 9, 2021

[DQM] Apply code-checks/format with misc-definitions-in-headers #34039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modification to PythiaFilterMotherSister #33806

Modification to PythiaFilterMotherSister #33806

mgratti commented May 21, 2021

cmsbuild commented May 21, 2021

cmsbuild commented May 21, 2021

agrohsje May 21, 2021

mgratti May 25, 2021

mgratti May 25, 2021 •

edited

agrohsje May 25, 2021

qliphy May 26, 2021

mgratti May 27, 2021

agrohsje May 27, 2021

cmsbuild commented May 28, 2021

cmsbuild commented May 28, 2021

SiewYan commented May 28, 2021

cmsbuild commented May 28, 2021

agrohsje Jun 1, 2021

mgratti Jun 1, 2021 •

edited

agrohsje Jun 3, 2021

mgratti commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

mgratti commented Jun 6, 2021 •

edited

SiewYan commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

agrohsje commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 8, 2021

Modification to PythiaFilterMotherSister #33806

Modification to PythiaFilterMotherSister #33806

Conversation

mgratti commented May 21, 2021

cmsbuild commented May 21, 2021

cmsbuild commented May 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgratti May 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented May 28, 2021

cmsbuild commented May 28, 2021

SiewYan commented May 28, 2021

cmsbuild commented May 28, 2021

Comparison Summary

Choose a reason for hiding this comment

mgratti Jun 1, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgratti commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

mgratti commented Jun 6, 2021 • edited

SiewYan commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

Comparison Summary

agrohsje commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 8, 2021

mgratti May 25, 2021 •

edited

mgratti Jun 1, 2021 •

edited

mgratti commented Jun 6, 2021 •

edited