Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recommended list of MET filters #33818

Merged
merged 4 commits into from Jul 12, 2021
Merged

Update recommended list of MET filters #33818

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7183278
PhysicsTools/NanoAOD/python/extraflags_cff.py
lathomas May 22, 2021
3f89dac
Update recommended list of MET filters, disable recomputation on MINIAOD
lathomas May 22, 2021
0af91ef
reverting back to original extraflags_cff.py
lathomas May 31, 2021
45fba54
Update MET filter recommendation
lathomas Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 13 additions & 29 deletions RecoMET/METFilters/python/metFilters_cff.py
View file
Open in desktop
Expand Up @@ -95,39 +95,23 @@
from RecoMET.METFilters.hfNoisyHitsFilter_cfi import *

metFilters = cms.Sequence(
HBHENoiseFilterResultProducer *
HBHENoiseFilter *
primaryVertexFilter*
# HBHENoiseIsoFilter*
# HcalStripHaloFilter *
CSCTightHaloFilter *
# hcalLaserEventFilter *
#Various proposals for updated halo filters.
##2015 proposals:
#CSCTightHaloTrkMuUnvetoFilter *
#CSCTightHalo2015Filter *
##2016 proposals
#globalTightHalo2016Filter*
#globalSuperTightHalo2016Filter*
EcalDeadCellTriggerPrimitiveFilter*
ecalBadCalibFilter*
# *goodVertices * trackingFailureFilter *
eeBadScFilter*
# ecalLaserCorrFilter *
# trkPOGFilters
chargedHadronTrackResolutionFilter *
BadChargedCandidateFilter*
BadPFMuonFilter *
BadPFMuonDzFilter *
hfNoisyHitsFilter *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still said to be "work in progress": don't you plan to compute this bit as well, and then select on it at the analysis level only depending on the updated reccommandations?

BadChargedCandidateSummer16Filter*
BadPFMuonSummer16Filter *
muonBadTrackFilter
goodVertices *
perrotta marked this conversation as resolved.
Show resolved Hide resolved
globalSuperTightHalo2016Filter *
perrotta marked this conversation as resolved.
Show resolved Hide resolved
HBHENoiseFilterResultProducer *
HBHENoiseFilter *
HBHENoiseIsoFilter *
EcalDeadCellTriggerPrimitiveFilter *
BadPFMuonFilter *
BadPFMuonDzFilter *
EcalDeadCellTriggerPrimitiveFilter *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated twice

ecalBadCalibFilter *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the twiki you point out, this is not among the recommended filters for 2016 data and MC (UL): do you plan to remove it with a modifier?

eeBadScFilter

)

from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal
phase2_hgcal.toReplaceWith(metFilters, metFilters.copyAndExclude([
HBHENoiseFilterResultProducer, HBHENoiseFilter, # No hcalnoise for hgcal
HBHENoiseFilterResultProducer, HBHENoiseFilter, HBHENoiseIsoFilter, # No hcalnoise for hgcal
eeBadScFilter # No EE
]))