New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate part of PPS modules to use esConsumes #33848
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33848/22870
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33848/22871
|
A new Pull Request was created by @fabferro (Fabrizio Ferro) for master. It involves the following packages: CalibPPS/ESProducers @malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @pohsun, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12bef7/15326/summary.html Comparison SummarySummary:
|
+1 |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As requested in issue #31061, this PR migrates to esConsumes the following packages:
CalibPPS and Dqm/CTPPS
PR validation:
Private checks have been done showing no changes in reconstruction, simulation and DQM plots of PPS.
No backport needed.
@jan-kaspar