[PUID] Add UL16 and UL16APV training configs

[singh-ramanpreet]

PR description:

• New training files (UL16 and UL16APV) and configs are added for Pileup Jet Id (AK4CHS)
• New working points, same for both UL16 and UL16APV
• default algo is not changed as discussed before in earlier PR Pileup Id training for UL18 #32418

PR validation:

• Test with UL16 and UL16APV trainings files with Summer20 samples cms-data/RecoJets-JetProducers#13

FYI: @alefisico @camclean @marinakolosova

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33857/22884

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @singh-ramanpreet (Ramanpreet Singh) for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

test parameters:

pull_request = cms-data/RecoJets-JetProducers#13

[mariadalfonso]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed097c/15341/summary.html
COMMIT: 469243b
CMSSW: CMSSW_12_0_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33857/15341/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

• 136.8523136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2/step2_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2.log
• 136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log
• 136.8311136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

Expand to see more relval errors ...

• 136.88811
• 1325.81
• 140.56
• 158.01
• 4.53
• 136.731
• 136.793
• 136.874
• 1000.0
• 1001.0
• 1306.0
• 135.4
• 312.0
• 1330.0
• 9.0
• 25.0
• 10042.0
• 10024.0
• 10824.0
• 25202.0
• 11634.0
• 12434.0
• 10224.0
• 23234.0
• 34634.0
• 28234.0
• 250202.181
• 34834.999

RelVals-INPUT

• 4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
• 136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
• 136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

Expand to see more relval errors ...

• 136.76111
• 136.7722
• 136.7721
• 136.77211
• 136.7802
• 136.7803
• 136.7952
• 136.8311
• 136.83111
• 136.8521
• 136.8522
• 136.8523
• 136.88811
• 140.5611
• 140.54
• 140.56
• 140.57
• 158.01
• 1325.5
• 1325.51
• 1325.6
• 1325.61
• 1325.7
• 1325.8
• 1325.81
• 1325.516
• 1325.5161
• 1329.1
• 1325.517
• 1325.518
• 134.0
• 144.6
• 1000.0
• 1001.0
• 1003.0
• 1001.2
• 1002.0
• 1030.0
• 1040.0

[singh-ramanpreet]

Fixed the bug.
Please test again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33857/22888

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33857 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed097c/15343/summary.html
COMMIT: 99fef56
CMSSW: CMSSW_12_0_X_2021-05-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33857/15343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

@perrotta, @jpata, @slava77
note we need this for the nanov9

[jpata]

+reconstruction

• no unexpected reco changes, code changes look OK
• please ensure UL16 and UL16APV trainings files with Summer20 samples cms-data/RecoJets-JetProducers#13 is merged before this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mariadalfonso]

@singh-ramanpreet
please backport this to 10_6_X
for the no change policy please have a look at your update for the PUidUL18
#32872

[qliphy]

+1