Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies needed by UBSAN builds #33933

Merged
merged 1 commit into from Jun 4, 2021

Conversation

dan131riley
Copy link

PR description:

Undefined behavior sanitizer builds have been failing with linker errors in Geometry/MTDNumberingBuilder:

GeometryMTDNumberingBuilder/MTDTopology.cc.o:(.data.rel+0x58): undefined reference to `typeinfo for GeomDet'

and DQM/TrackerRemapper:

DQMTrackerRemapper/SiStripTkMaps.cc.o:(.data.rel+0x218): undefined reference to `typeinfo for TPaletteAxis'

This PR adds the BuildFile.xml entries needed to resolve the missing typeinfos.

PR validation:

Trivial technical fix, builds successfully in CMSSW_12_0_UBSAN_X_2021-05-28-2300.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33933/23009

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

DQM/TrackerRemapper
Geometry/MTDNumberingBuilder

@civanch, @Dr15Jones, @ahmad3213, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @makortel, @srimanob, @jfernan2, @mdhildreth, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @fioriNTU, @jandrea, @idebruyn, @threus, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5776f4/15510/summary.html
COMMIT: 57a360d
CMSSW: CMSSW_12_0_X_2021-05-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33933/15510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 2, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Jun 2, 2021

+Upgrade

Technical PR, no change is expected. The PR test is OK.

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

+1

@cmsbuild cmsbuild merged commit 41b6e48 into cms-sw:master Jun 4, 2021
@dan131riley dan131riley deleted the fix-ubsan-linking branch June 14, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants