Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

bsunanda · 2021-06-07T20:53:45Z

PR description:

Try to update some of the region definitions for calorimeter and muon systems

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

… systems

cmsbuild · 2021-06-07T21:01:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34004/23126

This PR adds an extra 20KB to repository

cmsbuild · 2021-06-07T21:02:06Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/MuonSimData
SimG4Core/Application

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @ptcox, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-06-07T21:13:46Z

@cmsbuild Please test

cmsbuild · 2021-06-08T00:51:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de7b96/15737/summary.html
COMMIT: bbd8581
CMSSW: CMSSW_12_0_X_2021-06-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34004/15737/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648335
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2648306
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cvuosalo · 2021-06-08T15:09:28Z

+1

civanch · 2021-06-08T21:00:25Z

Geometry/MuonSimData/data/muonProdCuts/2026/v1/muonProdCuts.xml

+   <PartSelector path="//ShieldingBoronPoly.*"/>
+   <PartSelector path="//ME11SupportDisk"/>
+   <Parameter name="CMSCutsRegion" value="MuonIron" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="1.*mm"/>


@bsunanda , why MuonIron cut 1 mm? In my memory it should be 1 cm.

I want to move phase2/muonProdcuts.xml with its default cuts to muonProdcuts/2026/v1 and later replace them in the workflows. This is to keep the old record. I shall change the values for v2

civanch · 2021-06-08T21:02:55Z

Geometry/MuonSimData/data/muonProdCuts/2026/v1/muonProdCuts.xml

+   <Parameter name="CMSCutsRegion" value="MuonSensitive_DT-CSC" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="25.*mm"/>
+   <Parameter name="ProdCutsForElectrons" value="1.*mm"/>
+   <Parameter name="ProdCutsForPositrons" value="2.5*m"/>


max value should be 1 cm

civanch · 2021-06-08T21:03:16Z

Geometry/MuonSimData/data/muonProdCuts/2026/v1/muonProdCuts.xml

+   <PartSelector path="//REG.*"/>
+   <PartSelector path="//REH.*"/>
+   <Parameter name="CMSCutsRegion" value="MuonSensitive_RPC" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="8.5*m"/>


civanch · 2021-06-08T21:03:44Z

Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml

+  <SpecPar name="Muon">
+   <PartSelector path="//MUON"/>
+   <Parameter name="CMSCutsRegion" value="Muon" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="100.*mm"/>


civanch · 2021-06-08T21:04:02Z

Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml

+   <PartSelector path="//ShieldingBoronPoly.*"/>
+   <PartSelector path="//ME11SupportDisk"/>
+   <Parameter name="CMSCutsRegion" value="MuonIron" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="1.*mm"/>


@civanch Please check the values set in 2026/v2/muonProdcuts.xml. I do not want to modify the older values in v1 which will be kept as record

bsunanda · 2021-06-08T21:20:17Z

@cmsbuild Please test

cmsbuild · 2021-06-08T21:24:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34004/23193

This PR adds an extra 20KB to repository

cmsbuild · 2021-06-08T21:24:28Z

Pull request #34004 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again.

civanch · 2021-06-08T21:26:08Z

@bsunanda , I agree with v2 - they are reasonable.

cmsbuild · 2021-06-09T06:10:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de7b96/15791/summary.html
COMMIT: e5080b1
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34004/15791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2862520
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2862497
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

civanch · 2021-06-09T10:50:10Z

+1

cmsbuild · 2021-06-09T10:50:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-09T11:09:43Z

+1

Try to update some of the region definitions for calorimeter and muon…

bbd8581

… systems

cmsbuild added this to the CMSSW_12_0_X milestone Jun 7, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending labels Jun 7, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 7, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 7, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2021

cmsbuild added geometry-approved and removed geometry-pending labels Jun 8, 2021

civanch reviewed Jun 8, 2021

View reviewed changes

Take Vladimir's comments

e5080b1

cmsbuild removed code-checks-approved geometry-approved tests-approved labels Jun 8, 2021

cmsbuild added code-checks-pending geometry-pending tests-pending labels Jun 8, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2021

cmsbuild added fully-signed geometry-approved simulation-approved and removed geometry-pending pending-signatures simulation-pending labels Jun 9, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 9, 2021

cmsbuild merged commit 4b8ed95 into cms-sw:master Jun 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

bsunanda commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

bsunanda commented Jun 7, 2021

cmsbuild commented Jun 8, 2021

cvuosalo commented Jun 8, 2021

civanch Jun 8, 2021

bsunanda Jun 8, 2021

civanch Jun 8, 2021

civanch Jun 8, 2021

civanch Jun 8, 2021

civanch Jun 8, 2021

bsunanda Jun 8, 2021

bsunanda commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

civanch commented Jun 8, 2021

cmsbuild commented Jun 9, 2021

civanch commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

qliphy commented Jun 9, 2021

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

Conversation

bsunanda commented Jun 7, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

bsunanda commented Jun 7, 2021

cmsbuild commented Jun 8, 2021

Comparison Summary

cvuosalo commented Jun 8, 2021

civanch Jun 8, 2021

Choose a reason for hiding this comment

bsunanda Jun 8, 2021

Choose a reason for hiding this comment

civanch Jun 8, 2021

Choose a reason for hiding this comment

civanch Jun 8, 2021

Choose a reason for hiding this comment

civanch Jun 8, 2021

Choose a reason for hiding this comment

civanch Jun 8, 2021

Choose a reason for hiding this comment

bsunanda Jun 8, 2021

Choose a reason for hiding this comment

bsunanda commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

civanch commented Jun 8, 2021

cmsbuild commented Jun 9, 2021

Comparison Summary

civanch commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

qliphy commented Jun 9, 2021