Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

Merged
merged 2 commits into from Jun 9, 2021
Merged

Phase2-gem61 Try to update some of the region definitions for calorimeter and muon systems #34004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd8581
Try to update some of the region definitions for calorimeter and muon…
Jun 7, 2021
e5080b1
Take Vladimir's comments
Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
70 changes: 70 additions & 0 deletions Geometry/MuonSimData/data/muonProdCuts/2026/v1/muonProdCuts.xml
View file
Open in desktop
@@ -0,0 +1,70 @@
<?xml version="1.0"?>
<DDDefinition>
<SpecParSection label="ProductionCuts" eval="true">
<SpecPar name="Muon">
<PartSelector path="//MUON"/>
<Parameter name="CMSCutsRegion" value="Muon" eval="false"/>
<Parameter name="ProdCutsForGamma" value="100.*mm"/>
<Parameter name="ProdCutsForElectrons" value="10.*mm"/>
<Parameter name="ProdCutsForPositrons" value="10.*mm"/>
</SpecPar>
<SpecPar name="MuonIron">
<PartSelector path="//MGNT"/>
<PartSelector path="//YBSepar.*"/>
<PartSelector path="//COI.*"/>
<PartSelector path="//COCF"/>
<PartSelector path="//YB.*"/>
<PartSelector path="//ZStopSpace"/>
<PartSelector path="//SupportTubeForHE.*"/>
<PartSelector path="//YN.*"/>
<PartSelector path="//YE1.*"/>
<PartSelector path="//YE2.*"/>
<PartSelector path="//YE3.*"/>
<!-- if you want to re-stage YE4, then remove the comments around this element <PartSelector path="//YE4.*"/> -->
<PartSelector path="//ShieldingME4.*"/>
<PartSelector path="//ShieldingBoronPoly.*"/>
<PartSelector path="//ME11SupportDisk"/>
<Parameter name="CMSCutsRegion" value="MuonIron" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.*mm"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda , why MuonIron cut 1 mm? In my memory it should be 1 cm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to move phase2/muonProdcuts.xml with its default cuts to muonProdcuts/2026/v1 and later replace them in the workflows. This is to keep the old record. I shall change the values for v2

<Parameter name="ProdCutsForElectrons" value="1.*mm"/>
<Parameter name="ProdCutsForPositrons" value="1.*mm"/>
</SpecPar>
<SpecPar name="MuonChamber">
<PartSelector path="//MB.*N"/>
<PartSelector path="//MB.*P"/>
<PartSelector path="//ME.*Space"/>
<PartSelector path="//RR.*"/>
<PartSelector path="//GE.*"/>
<Parameter name="CMSCutsRegion" value="MuonChamber" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.*mm"/>
<Parameter name="ProdCutsForElectrons" value="0.002*mm"/>
<Parameter name="ProdCutsForPositrons" value="0.002*mm"/>
</SpecPar>
<SpecPar name="MuonSensitive_DT-CSC">
<!-- 1 keV for gamma/e-, 1 MeV for e+ -->
<PartSelector path="//MB.*PhiGas"/>
<PartSelector path="//MB.*ZGas"/>
<PartSelector path="//ME.*ActiveGasVol"/>
<Parameter name="CMSCutsRegion" value="MuonSensitive_DT-CSC" eval="false"/>
<Parameter name="ProdCutsForGamma" value="25.*mm"/>
<Parameter name="ProdCutsForElectrons" value="1.*mm"/>
<Parameter name="ProdCutsForPositrons" value="2.5*m"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max value should be 1 cm

</SpecPar>
<SpecPar name="MuonSensitive_RPC">
<!-- 10 keV for gamma/e-, 1 MeV for e+ -->
<PartSelector path="//MB.*RPC_.*Gas.*"/>
<!-- <PartSelector path="//REA.*"/> -->
<PartSelector path="//REB.*"/>
<PartSelector path="//REC.*"/>
<!-- <PartSelector path="//RED.*"/> -->
<PartSelector path="//REE.*"/>
<PartSelector path="//REF.*"/>
<PartSelector path="//REG.*"/>
<PartSelector path="//REH.*"/>
<Parameter name="CMSCutsRegion" value="MuonSensitive_RPC" eval="false"/>
<Parameter name="ProdCutsForGamma" value="8.5*m"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 cm

<Parameter name="ProdCutsForElectrons" value="8.*mm"/>
<Parameter name="ProdCutsForPositrons" value="2.5*m"/>
</SpecPar>
</SpecParSection>
</DDDefinition>
71 changes: 71 additions & 0 deletions Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml
View file
Open in desktop
@@ -0,0 +1,71 @@
<?xml version="1.0"?>
<DDDefinition>
<SpecParSection label="ProductionCuts" eval="true">
<SpecPar name="Muon">
<PartSelector path="//MUON"/>
<Parameter name="CMSCutsRegion" value="Muon" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.0*cm"/>
<Parameter name="ProdCutsForElectrons" value="1.0*cm"/>
<Parameter name="ProdCutsForPositrons" value="1.0*cm"/>
</SpecPar>
<SpecPar name="MuonIron">
<PartSelector path="//MGNT"/>
<PartSelector path="//YBSepar.*"/>
<PartSelector path="//COI.*"/>
<PartSelector path="//COCF"/>
<PartSelector path="//YB.*"/>
<PartSelector path="//ZStopSpace"/>
<PartSelector path="//SupportTubeForHE.*"/>
<PartSelector path="//YN.*"/>
<PartSelector path="//YE1.*"/>
<PartSelector path="//YE2.*"/>
<PartSelector path="//YE3.*"/>
<!-- if you want to re-stage YE4, then remove the comments around this element <PartSelector path="//YE4.*"/> -->
<PartSelector path="//ShieldingME4.*"/>
<PartSelector path="//ShieldingBoronPoly.*"/>
<PartSelector path="//ME11SupportDisk"/>
<Parameter name="CMSCutsRegion" value="MuonIron" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.0*cm"/>
<Parameter name="ProdCutsForElectrons" value="1.0*mm"/>
<Parameter name="ProdCutsForPositrons" value="1.0*mm"/>
</SpecPar>
<SpecPar name="MuonChamber">
<PartSelector path="//MB.*N"/>
<PartSelector path="//MB.*P"/>
<PartSelector path="//ME.*Space"/>
<PartSelector path="//RR.*"/>
<PartSelector path="//GE.*"/>
<Parameter name="CMSCutsRegion" value="MuonChamber" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.0*mm"/>
<Parameter name="ProdCutsForElectrons" value="0.002*mm"/>
<Parameter name="ProdCutsForPositrons" value="0.002*mm"/>
</SpecPar>
<SpecPar name="MuonSensitive_DT-CSC">
<!-- 1 keV for gamma/e-, 1 MeV for e+ -->
<PartSelector path="//MB.*PhiGas"/>
<PartSelector path="//MB.*ZGas"/>
<PartSelector path="//ME.*ActiveGasVol"/>
<PartSelector path="//GHA.*"/>
<Parameter name="CMSCutsRegion" value="MuonSensitive_DT-CSC" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.0*cm"/>
<Parameter name="ProdCutsForElectrons" value="1.0*mm"/>
<Parameter name="ProdCutsForPositrons" value="1.0*cm"/>
</SpecPar>
<SpecPar name="MuonSensitive_RPC">
<!-- 10 keV for gamma/e-, 1 MeV for e+ -->
<PartSelector path="//MB.*RPC_.*Gas.*"/>
<!-- <PartSelector path="//REA.*"/> -->
<PartSelector path="//REB.*"/>
<PartSelector path="//REC.*"/>
<!-- <PartSelector path="//RED.*"/> -->
<PartSelector path="//REE.*"/>
<PartSelector path="//REF.*"/>
<PartSelector path="//REG.*"/>
<PartSelector path="//REH.*"/>
<Parameter name="CMSCutsRegion" value="MuonSensitive_RPC" eval="false"/>
<Parameter name="ProdCutsForGamma" value="1.0*cm"/>
<Parameter name="ProdCutsForElectrons" value="8.0*mm"/>
<Parameter name="ProdCutsForPositrons" value="1.0*cm"/>
</SpecPar>
</SpecParSection>
</DDDefinition>
2 changes: 1 addition & 1 deletion SimG4Core/Application/src/StackingAction.cc
View file
Open in desktop
Expand Up @@ -388,7 +388,7 @@ void StackingAction::initPointer() {
trackerRegions.push_back(reg);
}
if (savePDandCinCalo && (rname == "HcalRegion" || rname == "EcalRegion" || rname == "PreshowerSensRegion" ||
rname == "PreshowerRegion")) {
rname == "PreshowerRegion" || rname == "APDRegion" || rname == "HGCalRegion")) {
caloRegions.push_back(reg);
}
if (savePDandCinMuon && (rname == "MuonChamber" || rname == "MuonSensitive_RPC" || rname == "MuonIron" ||
Expand Down